[jira] [Comment Edited] (DERBY-7076) replace old "new FileInputStreamReader()" from java.io to the java.nio Files.newInputStream

["Yasser Mustafa Bazzi Bordonal (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098010#comment-17098010 ] 

Yasser Mustafa Bazzi Bordonal edited comment on DERBY-7076 at 5/2/20, 4:33 PM:
-------------------------------------------------------------------------------

Hi, although not much beneficial the old  java.io "new FileInput/Output"  calls finalize even when close is called, these new methods on java.nio create the same Input or Output without the finalize thus possibly avoiding a GC.

As far as these errors the patch probably didn't apply well, these errors seems to been a missing import "java.nio.file.Path".

If needed i can create another patch.

Thanks for the feedback.


was (Author: yassermb):
Hi, although not much beneficial the old  java.io "new FileInput/Output"  calls finalize even when close is called, these new methods on java.nio create the same Input or Output without the finalize.

As far as these errors the patch probably didn't apply well, these errors seems to been a missing import "java.nio.file.Path".

If needed i can create another patch.

Thanks for the feedback.

> replace old "new FileInputStreamReader()" from java.io to the java.nio Files.newInputStream
> -------------------------------------------------------------------------------------------
>
>                 Key: DERBY-7076
>                 URL: https://issues.apache.org/jira/browse/DERBY-7076
>             Project: Derby
>          Issue Type: Task
>            Reporter: Yasser Mustafa Bazzi Bordonal
>            Priority: Minor
>         Attachments: nio.diff
>
>
> This should avoid some allocations done by the old java.io and not disrupt any major part of derby, since im a new contributor i would like feedback to see if this breaks anything since im not able to run the tests on my computer but it builds and works just fine.
> Thanks in advance.
> [^nio.diff]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)