[GitHub] [iceberg] openinx commented on a change in pull request #2105: Flink: Initial implementation of Flink source with the new FLIP-27 source interface

[GitBox <gi...@apache.org>]

openinx commented on a change in pull request #2105:
URL: https://github.com/apache/iceberg/pull/2105#discussion_r591009616



##########
File path: flink/src/main/java/org/apache/iceberg/flink/source/DataIterator.java
##########
@@ -79,6 +83,27 @@ InputFile getInputFile(String location) {
     return inputFiles.get(location);
   }
 
+  public void seek(CheckpointedPosition checkpointedPosition)  {

Review comment:
       The `inputFiles` in DataIterator is a in-memory cache to get the given decrypted InputFile path by decrypted location.  We maintain those <location,  decryptedInputFile> into map because we are trying to get all the decrypted infos once ( Some `EncryptionManager` implementation will use this feature to request them in a batch RPC call).  It don't have relationship to row-level delete in format v2,  we could fetch the <location, decryptedInputFile> one by one but that may produce many RPC to a key server.  




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org