You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Loyal-Young (via GitHub)" <gi...@apache.org> on 2026/10/15 05:18:22 UTC
[PR] fix(ai): scope custom prompt templates to the operator [rocketmq-dashboard]
Loyal-Young opened a new pull request, #6707:
URL: https://github.com/apache/rocketmq-dashboard/pull/6707
## What is the purpose of the change
Fixes #6706. Custom prompt templates should belong to the signed-in operator whose browser stored them. Previously every account on the same origin read and wrote one shared `localStorage` key.
## Brief changelog
- Scope custom-template reads, saves, and deletes by the operator's stable user ID, with username fallback for older sessions without an ID.
- Refresh the catalog when the signed-in account changes and hide the prior catalog during that transition.
- Keep the existing unscoped key only for deployments without a signed-in operator. Its original owner is unknown, so the change does not assign its contents to any account.
- Add storage isolation and mounted modal account-switch regressions.
## Verification
- Reviewed the original storage path: `readCustomPromptTemplates`, `writeCustomPromptTemplates`, and delete all used the same fixed key regardless of operator identity.
- The prompt-template utility and modal suites passed (17 tests). The modal suite also passed again after the final render guard (4 tests).
- App TypeScript check, changed-file ESLint, and `git diff --check` passed.
## AI assistance
AI assistance helped trace the template storage and authentication flow, draft the account-switch tests, and review the data migration choice. I inspected the final diff and ran the checks above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ai): scope custom prompt templates to the operator [rocketmq-dashboard]
Posted by "Loyal-Young (via GitHub)" <gi...@apache.org>.
Loyal-Young commented on PR #6707:
URL: https://github.com/apache/rocketmq-dashboard/pull/6707#issuecomment-6261573710
Progress update (2026-10-19): GitHub currently reports the branch as mergeable. All five current CI checks pass. The change is ready for maintainer review. I will follow up on any new feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(ai): scope custom prompt templates to the operator [rocketmq-dashboard]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #6707:
URL: https://github.com/apache/rocketmq-dashboard/pull/6707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org