[jira] [Commented] (HBASE-13498) Add more docs and a basic check for storage policy handling

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-13498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502556#comment-14502556 ] 

Hadoop QA commented on HBASE-13498:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12726522/HBASE-13498.2.patch.txt
  against master branch at commit 3bf69761e172163df320346edfc28f10d4fb9da7.
  ATTACHMENT ID: 12726522

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 4 new or modified tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/13742//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/13742//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/13742//artifact/patchprocess/checkstyle-aggregate.html

  Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/13742//console

This message is automatically generated.

> Add more docs and a basic check for storage policy handling
> -----------------------------------------------------------
>
>                 Key: HBASE-13498
>                 URL: https://issues.apache.org/jira/browse/HBASE-13498
>             Project: HBase
>          Issue Type: Sub-task
>          Components: wal
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Minor
>             Fix For: 2.0.0, 1.1.0
>
>         Attachments: HBASE-13498.1.patch.txt, HBASE-13498.2.patch.txt
>
>
> some minor clean up:
> * make sure our javadocs contain enough info for someone unfamiliar with HDFS storage policies to get started.
> * add a basic test that verifies things happily continue on non-supported versions, or with non-supported policies
> * clarify some log messages



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)