You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ehsun7b <gi...@git.apache.org> on 2017/03/16 10:46:20 UTC
[GitHub] spark pull request #17314: Openet labs jira spark 15790
GitHub user ehsun7b opened a pull request:
https://github.com/apache/spark/pull/17314
Openet labs jira spark 15790
## What changes were proposed in this pull request?
@Since annotation has been added to all classes at package org.apache.spark.ml
This is a partial fix for SPARK-15790
Future work is to add @Since annotation at method levels for all classes at org.apache.spark.ml
## How was this patch tested?
This fix is documentation stuff. ./dev/run-tests was successful.
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Openet-Labs/spark openet-labs-jira-SPARK-15790
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17314.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17314
----
commit 9d09227567d9baf234a9660603343ced55efd054
Author: Ehsun Behravesh <eh...@openet.com>
Date: 2017-03-16T07:47:25Z
first commit for test - one empty line
commit 7c01d11c7394a9ad9c37026100feb5368f3e30eb
Author: Ehsun Behravesh <eh...@openet.com>
Date: 2017-03-16T10:41:44Z
JIRA SPARK-15790: @Since annotation added for classes at package org.apache.spark.ml
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17314: [SPARK-15790][MLlib] Audit @Since annotations in ...
Posted by ehsun7b <gi...@git.apache.org>.
Github user ehsun7b commented on a diff in the pull request:
https://github.com/apache/spark/pull/17314#discussion_r107061443
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/AFTSurvivalRegressionWrapper.scala ---
@@ -30,6 +32,7 @@ import org.apache.spark.ml.regression.{AFTSurvivalRegression, AFTSurvivalRegress
import org.apache.spark.ml.util._
import org.apache.spark.sql.{DataFrame, Dataset}
+@Since("2.0.0")
private[r] class AFTSurvivalRegressionWrapper private (
--- End diff --
OK,
We have added the annotations already and the versions are very precise because we have developed a tool to find the exact version a class appeared in, for the first time.
Should we remove the annotations from private classes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17314: [SPARK-15790][MLlib] Audit @Since annotations in ...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/17314#discussion_r106798435
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/AFTSurvivalRegressionWrapper.scala ---
@@ -30,6 +32,7 @@ import org.apache.spark.ml.regression.{AFTSurvivalRegression, AFTSurvivalRegress
import org.apache.spark.ml.util._
import org.apache.spark.sql.{DataFrame, Dataset}
+@Since("2.0.0")
private[r] class AFTSurvivalRegressionWrapper private (
--- End diff --
here and many files below are private though?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17314: Openet labs jira spark 15790
Posted by ehsun7b <gi...@git.apache.org>.
Github user ehsun7b closed the pull request at:
https://github.com/apache/spark/pull/17314
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17314: Fix for JIRA ticket SPARK-15790
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17314
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17314: Openet labs jira spark 15790
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17314
This looks like it is from some other project. What is Openet labs? See http://spark.apache.org/contributing.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17314: [SPARK-15790][MLlib] Audit @Since annotations in ML
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17314
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17314: [SPARK-15790][MLlib] Audit @Since annotations in ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17314#discussion_r107127189
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/AFTSurvivalRegressionWrapper.scala ---
@@ -30,6 +32,7 @@ import org.apache.spark.ml.regression.{AFTSurvivalRegression, AFTSurvivalRegress
import org.apache.spark.ml.util._
import org.apache.spark.sql.{DataFrame, Dataset}
+@Since("2.0.0")
private[r] class AFTSurvivalRegressionWrapper private (
--- End diff --
Hm, I think just for consistency, we shouldn't mark non-public APIs. Can you re-run this tool but exclude private classes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17314: Fix for JIRA ticket SPARK-15790
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17314
Please fix the title -- see the link I sent you
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17314: [SPARK-15790][MLlib] Audit @Since annotations in ...
Posted by ehsun7b <gi...@git.apache.org>.
Github user ehsun7b commented on a diff in the pull request:
https://github.com/apache/spark/pull/17314#discussion_r107355136
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/AFTSurvivalRegressionWrapper.scala ---
@@ -30,6 +32,7 @@ import org.apache.spark.ml.regression.{AFTSurvivalRegression, AFTSurvivalRegress
import org.apache.spark.ml.util._
import org.apache.spark.sql.{DataFrame, Dataset}
+@Since("2.0.0")
private[r] class AFTSurvivalRegressionWrapper private (
--- End diff --
Yes we can, but it takes some time... Finding the API is done by the tool, but adding the annotation was done manually.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17314: Openet labs jira spark 15790
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17314
@ehsun7b close this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17314: Fix for JIRA ticket SPARK-15790
Posted by ehsun7b <gi...@git.apache.org>.
GitHub user ehsun7b reopened a pull request:
https://github.com/apache/spark/pull/17314
Fix for JIRA ticket SPARK-15790
## What changes were proposed in this pull request?
This is the partial fix for this JIRA: https://issues.apache.org/jira/browse/SPARK-15790
`Since `annotation has been added to all classes at package `org.apache.spark.ml` at class level only.
Future work is to add `Since `annotation at method levels for all classes at `org.apache.spark.ml`
## How was this patch tested?
This fix is documentation stuff. ./dev/run-tests was successful.
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Openet-Labs/spark openet-labs-jira-SPARK-15790
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17314.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17314
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17314: Openet labs jira spark 15790
Posted by ehsun7b <gi...@git.apache.org>.
Github user ehsun7b commented on the issue:
https://github.com/apache/spark/pull/17314
Should I re-open the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17314: Fix for JIRA ticket SPARK-15790
Posted by ehsun7b <gi...@git.apache.org>.
Github user ehsun7b commented on the issue:
https://github.com/apache/spark/pull/17314
I updated the title and provided more details about the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17314: Openet labs jira spark 15790
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17314
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17314: Openet labs jira spark 15790
Posted by ehsun7b <gi...@git.apache.org>.
Github user ehsun7b commented on the issue:
https://github.com/apache/spark/pull/17314
It's our fork of Apache Spark.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17314: Openet labs jira spark 15790
Posted by ehsun7b <gi...@git.apache.org>.
Github user ehsun7b commented on the issue:
https://github.com/apache/spark/pull/17314
Yes it is for upstream Spark. Our team is going to contribute on fixing Apache Spark bugs or open JIRA tickets for documentations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17314: [SPARK-15790][MLlib] Audit @Since annotations in ...
Posted by ehsun7b <gi...@git.apache.org>.
Github user ehsun7b commented on a diff in the pull request:
https://github.com/apache/spark/pull/17314#discussion_r106844740
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/AFTSurvivalRegressionWrapper.scala ---
@@ -30,6 +32,7 @@ import org.apache.spark.ml.regression.{AFTSurvivalRegression, AFTSurvivalRegress
import org.apache.spark.ml.util._
import org.apache.spark.sql.{DataFrame, Dataset}
+@Since("2.0.0")
private[r] class AFTSurvivalRegressionWrapper private (
--- End diff --
Private classes must not have the annotation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17314: [SPARK-15790][MLlib] Audit @Since annotations in ...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17314#discussion_r106847289
--- Diff: mllib/src/main/scala/org/apache/spark/ml/r/AFTSurvivalRegressionWrapper.scala ---
@@ -30,6 +32,7 @@ import org.apache.spark.ml.regression.{AFTSurvivalRegression, AFTSurvivalRegress
import org.apache.spark.ml.util._
import org.apache.spark.sql.{DataFrame, Dataset}
+@Since("2.0.0")
private[r] class AFTSurvivalRegressionWrapper private (
--- End diff --
No real point because the annotations are for end users and these don't appear in APIs or docs
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17314: Openet labs jira spark 15790
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17314
OK. Is this intended as a pull request for upstream Spark? (We get a couple accidental PRs a week where someone intended to open a PR against their fork) Reformat the title and explain a bit more about the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17314: [SPARK-15790][MLlib] Audit @Since annotations in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17314
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17314: Openet labs jira spark 15790
Posted by ehsun7b <gi...@git.apache.org>.
Github user ehsun7b commented on the issue:
https://github.com/apache/spark/pull/17314
Why? @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17314: [SPARK-15790][MLlib] Audit @Since annotations in ML
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/17314
@ehsun7b is this still active? if it's not a WIP then you can close it for now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org