[GitHub] [flink] XComp commented on a diff in pull request #22546: [FLINK-32032] Upgrade to flink-shaded 17.0

["XComp (via GitHub)" <gi...@apache.org>]

XComp commented on code in PR #22546:
URL: https://github.com/apache/flink/pull/22546#discussion_r1190164832


##########
pom.xml:
##########
@@ -376,7 +376,7 @@ under the License.
 			<dependency>
 				<groupId>org.apache.flink</groupId>
 				<artifactId>flink-shaded-netty</artifactId>
-				<version>4.1.90.Final-${flink.shaded.version}</version>

Review Comment:
   The commit message doesn't match the change? :thinking: 



##########
pom.xml:
##########
@@ -122,8 +122,8 @@ under the License.
 		<flink.forkCountUnitTest>4</flink.forkCountUnitTest>
 		<flink.reuseForks>true</flink.reuseForks>
 		<flink.surefire.baseArgLine>-XX:+UseG1GC -Xms256m</flink.surefire.baseArgLine>
-		<flink.shaded.version>16.1</flink.shaded.version>
-		<flink.shaded.jackson.version>2.13.4</flink.shaded.jackson.version>

Review Comment:
   There's also `<curator.version/>` property further down in the file that is used for test code. I suggest that we keep these two dependencies in sync. We would have to change some parameter initialization (see [CURATOR-663](https://issues.apache.org/jira/browse/CURATOR-663)) if we decide to upgrade.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org