You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2021/02/23 11:22:37 UTC
[GitHub] [struts] kerttup opened a new pull request #474: WW-2411 Add a maxlength attribute to the textarea tag
kerttup opened a new pull request #474:
URL: https://github.com/apache/struts/pull/474
Maxlength attribute added to textarea tag
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] kerttup commented on pull request #474: WW-2411 Add a maxlength attribute to the textarea tag
Posted by GitBox <gi...@apache.org>.
kerttup commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-798849349
Hi @lukaszlenart, what do you mean with plan port? This was my first pull request so I am new to this and dont know the practices yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] coveralls commented on pull request #474: WW-2411 Add a maxlength attribute to the textarea tag
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-784196812
[](https://coveralls.io/builds/37370896)
Coverage increased (+0.0009%) to 49.898% when pulling **92afe8b85e865b6e806bf97a67339444c66ba37d on kerttup:Branch_1** into **eb8bc5e910f1da575e2bc8df752c97912a41378f on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart merged pull request #474: WW-2411 Add a maxlength attribute to the textarea tag
Posted by GitBox <gi...@apache.org>.
lukaszlenart merged pull request #474:
URL: https://github.com/apache/struts/pull/474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] lukaszlenart commented on pull request #474: WW-2411 Add a maxlength attribute to the textarea tag
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-784952140
Also would you mind adding `minlength`?
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea#attributes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart commented on pull request #474: WW-2411 Add a maxlength attribute to the textarea tag
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-798873619
We are currently developing two versions of Struts
- `master` branch represents incoming [Struts 2.6](https://issues.apache.org/jira/projects/WW/versions/12340222)
- `struts-2-5-x` branch is used to maintain current [Struts 2.5.x](https://issues.apache.org/jira/projects/WW/versions/12349611)
You addressed your fix just against the `master` branch which means it will be included in Struts 2.6 - this is fine if you can wait on that version to be released probably in a few months. If you would like to see your fix early, you must _port_ it to `struts-2-5-x` branch by cherry-picking the changes and opening a new PR against `struts-2-5-x` branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] coveralls edited a comment on pull request #474: WW-2411 Add a maxlength attribute to the textarea tag
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-784196812
[](https://coveralls.io/builds/37478080)
Coverage increased (+0.002%) to 49.899% when pulling **255b563dcf34d73ad6d94f71bf1331147714441a on kerttup:Branch_1** into **eb8bc5e910f1da575e2bc8df752c97912a41378f on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] kerttup commented on pull request #474: WW-2411 Add a maxlength attribute to the textarea tag
Posted by GitBox <gi...@apache.org>.
kerttup commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-798887582
Thanks for the clarification. I think this can wait until the next version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart commented on pull request #474: WW-2411 Add a maxlength attribute to the textarea tag
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-784951793
You must also modify [`template/simple/textarea.ftl`](https://github.com/apache/struts/blob/master/core/src/main/resources/template/simple/textarea.ftl#L21-L47), add something like this:
```
<#if parameters. maxlength?has_content>
maxlength ="${parameters. maxlength}"<#rt/>
</#if>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart commented on pull request #474: WW-2411 Add a maxlength attribute to the textarea tag
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-787413059
@kerttup do you plan port these changes into 2.5.x branch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] kerttup commented on pull request #474: WW-2411 Add a maxlength attribute to the textarea tag
Posted by GitBox <gi...@apache.org>.
kerttup commented on pull request #474:
URL: https://github.com/apache/struts/pull/474#issuecomment-786594208
Modified textarea.ftl and added also minlength attribute.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org