[GitHub] [cassandra-in-jvm-dtest-api] dcapwell commented on a change in pull request #13: CASSANDRA-15386 - default to 3 datadirs during in-jvm dtests

[GitBox <gi...@apache.org>]

dcapwell commented on a change in pull request #13:
URL: https://github.com/apache/cassandra-in-jvm-dtest-api/pull/13#discussion_r483891478



##########
File path: src/main/java/org/apache/cassandra/distributed/shared/AbstractBuilder.java
##########
@@ -268,6 +274,14 @@ public B withInstanceInitializer(BiConsumer<ClassLoader, Integer> instanceInitia
         return (B) this;
     }
 
+    public B withDataDirCount(int datadirCount)
+    {
+        assert datadirCount > 0;

Review comment:
       would be nice to leave a message, like `"data dir count requires a positive number but given " + datadirCount`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org