You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com> on 2016/08/01 18:10:28 UTC

Re: Review Request 50317: SAMZA-978: update md files to resolve inconsistent links, broken links and some confusing sentences

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50317/#review144365
-----------------------------------------------------------


Ship it!




Ship It!

- Yi Pan (Data Infrastructure)


On July 22, 2016, 11:23 p.m., Fred Ji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50317/
> -----------------------------------------------------------
> 
> (Updated July 22, 2016, 11:23 p.m.)
> 
> 
> Review request for samza, Jon Bringhurst, Jagadish Venkatraman, and Yi Pan (Data Infrastructure).
> 
> 
> Bugs: SAMZA-978
>     https://issues.apache.org/jira/browse/SAMZA-978
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> 1. resolve the inconsistent next section link at the end of each section on samza.apache.org/learn/documentation/0.10/; 
> 2. resolove some broken links such as Coda Hale's metrics library and Linux CGroup; 
> 3. update some sentences or rephrase to make description clearer.
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/versioned/api/overview.md 6712344e84e19883b857e00549db2acb101c7e0e 
>   docs/learn/documentation/versioned/comparisons/mupd8.md 53417f91019c08d470d101685b6c40dad112bb18 
>   docs/learn/documentation/versioned/comparisons/storm.md 58cb50895e7a419a7bede8911cd5b7f21fb487c4 
>   docs/learn/documentation/versioned/container/coordinator-stream.md 98c1a845cda5ca2a53ee58b55508fc93492b982d 
>   docs/learn/documentation/versioned/container/event-loop.md 116238312df7071747cbbc14bc9c46f558755195 
>   docs/learn/documentation/versioned/container/metrics.md 0423155537b0095b9efcfb40757e8de17b640ffd 
>   docs/learn/documentation/versioned/container/samza-container.md 55bec9813ca006757db046e6e85259b4d2e8c770 
>   docs/learn/documentation/versioned/container/state-management.md 320392cd4412b459a093ab9657b7264cee42958b 
>   docs/learn/documentation/versioned/container/windowing.md b10e5d4eba61cb5da026af828d89d558457a6b16 
>   docs/learn/documentation/versioned/hdfs/producer.md 0865a351b48c0b00e32282d2d7e44dfeae09b4ec 
>   docs/learn/documentation/versioned/index.html 1e79bd6f39ee67b5a2b74222d647342990bbbe23 
>   docs/learn/documentation/versioned/yarn/isolation.md a76f6fd0f93482c085b15bb1b2c313a913508bcc 
>   docs/learn/documentation/versioned/yarn/yarn-host-affinity.md af6367da4f5611e208c9fb8426554c4a9c4ad6c8 
> 
> Diff: https://reviews.apache.org/r/50317/diff/
> 
> 
> Testing
> -------
> 
> Basic unit tests and checkstyleTest passed.
> 1. Run unit tests:
>   ./gradlew clean build
> 2. Check if your code follows the coding conventions:
>   ./gradlew checkstyleMain checkstyleTest
>   
> Brought up Jekyll, built a local website out of markdown pages, and verified the changes and links on localhost server.
> 
> 
> Thanks,
> 
> Fred Ji
> 
>