You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Ahmed Radwan (JIRA)" <ji...@apache.org> on 2012/08/30 20:57:07 UTC
[jira] [Created] (HADOOP-8749) HADOOP-8031 changed the way in which
relative xincludes are handled in Configuration.
Ahmed Radwan created HADOOP-8749:
------------------------------------
Summary: HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
Key: HADOOP-8749
URL: https://issues.apache.org/jira/browse/HADOOP-8749
Project: Hadoop Common
Issue Type: Bug
Components: conf
Reporter: Ahmed Radwan
Assignee: Ahmed Radwan
The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in
which relative xincludes are handled in Configuration.
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445194#comment-13445194 ]
Ahmed Radwan commented on HADOOP-8749:
--------------------------------------
Basically we need to use parse(InputStream is, String systemId) which provides a base for resolving relative URIs. Here is a new patch that fixes this issue.
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in
which relative xincludes are handled in Configuration.
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448482#comment-13448482 ]
Todd Lipcon commented on HADOOP-8749:
-------------------------------------
+1, looks good to me, please submit patch so that Hudson can check it out.
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in
which relative xincludes are handled in Configuration.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450584#comment-13450584 ]
Hudson commented on HADOOP-8749:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #1158 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1158/])
HADOOP-8749. HADOOP-8031 changed the way in which relative xincludes are handled in Configuration. (ahmed via tucu) (Revision 1381703)
Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381703
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Fix For: 2.2.0-alpha
>
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch, HADOOP-8749_rev3.patch, HADOOP-8749_rev4.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (HADOOP-8749) HADOOP-8031 changed the way in which
relative xincludes are handled in Configuration.
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy closed HADOOP-8749.
---------------------------------
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Fix For: 2.0.2-alpha
>
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch, HADOOP-8749_rev3.patch, HADOOP-8749_rev4.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8749) HADOOP-8031 changed the way in which
relative xincludes are handled in Configuration.
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated HADOOP-8749:
---------------------------------
Attachment: HADOOP-8749_rev4.patch
I have modified the test case again to have a proper way of cleaning up the created directory.
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch, HADOOP-8749_rev3.patch, HADOOP-8749_rev4.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in
which relative xincludes are handled in Configuration.
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445264#comment-13445264 ]
Todd Lipcon commented on HADOOP-8749:
-------------------------------------
I verified that this fix worked on my cluster. Will wait for the test case, though. Thanks for looking into this, Ahmed!
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: HADOOP-8749.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8749) HADOOP-8031 changed the way in which
relative xincludes are handled in Configuration.
Posted by "Alejandro Abdelnur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alejandro Abdelnur updated HADOOP-8749:
---------------------------------------
Resolution: Fixed
Fix Version/s: 2.2.0-alpha
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Thanks Ahmed. Committed to trunk and branch-2.
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Fix For: 2.2.0-alpha
>
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch, HADOOP-8749_rev3.patch, HADOOP-8749_rev4.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in
which relative xincludes are handled in Configuration.
Posted by "Aaron T. Myers (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446473#comment-13446473 ]
Aaron T. Myers commented on HADOOP-8749:
----------------------------------------
Great investigation, Ahmed. I noticed that this behavior had changed, but from a quick look couldn't find any obviously relevant changes.
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: HADOOP-8749.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in
which relative xincludes are handled in Configuration.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449896#comment-13449896 ]
Hudson commented on HADOOP-8749:
--------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2758 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2758/])
HADOOP-8749. HADOOP-8031 changed the way in which relative xincludes are handled in Configuration. (ahmed via tucu) (Revision 1381703)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381703
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Fix For: 2.2.0-alpha
>
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch, HADOOP-8749_rev3.patch, HADOOP-8749_rev4.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in
which relative xincludes are handled in Configuration.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449955#comment-13449955 ]
Hudson commented on HADOOP-8749:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2719 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2719/])
HADOOP-8749. HADOOP-8031 changed the way in which relative xincludes are handled in Configuration. (ahmed via tucu) (Revision 1381703)
Result = FAILURE
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381703
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Fix For: 2.2.0-alpha
>
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch, HADOOP-8749_rev3.patch, HADOOP-8749_rev4.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in
which relative xincludes are handled in Configuration.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450630#comment-13450630 ]
Hudson commented on HADOOP-8749:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #1189 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1189/])
HADOOP-8749. HADOOP-8031 changed the way in which relative xincludes are handled in Configuration. (ahmed via tucu) (Revision 1381703)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381703
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Fix For: 2.2.0-alpha
>
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch, HADOOP-8749_rev3.patch, HADOOP-8749_rev4.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8749) HADOOP-8031 changed the way in which
relative xincludes are handled in Configuration.
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated HADOOP-8749:
---------------------------------
Attachment: HADOOP-8749_rev2.patch
Thanks Todd, ATM and Steve!
Here is the updated patch. I have added a test case to cover when a relative path is used in the XInclude.
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in
which relative xincludes are handled in Configuration.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448523#comment-13448523 ]
Hadoop QA commented on HADOOP-8749:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543777/HADOOP-8749_rev2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
org.apache.hadoop.conf.TestConfiguration
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1400//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1400//console
This message is automatically generated.
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in
which relative xincludes are handled in Configuration.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448593#comment-13448593 ]
Hadoop QA commented on HADOOP-8749:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543828/HADOOP-8749_rev4.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1403//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1403//console
This message is automatically generated.
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch, HADOOP-8749_rev3.patch, HADOOP-8749_rev4.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in
which relative xincludes are handled in Configuration.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13448581#comment-13448581 ]
Hadoop QA commented on HADOOP-8749:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12543827/HADOOP-8749_rev3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1402//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1402//console
This message is automatically generated.
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch, HADOOP-8749_rev3.patch, HADOOP-8749_rev4.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8749) HADOOP-8031 changed the way in which
relative xincludes are handled in Configuration.
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated HADOOP-8749:
---------------------------------
Status: Patch Available (was: Open)
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in
which relative xincludes are handled in Configuration.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449901#comment-13449901 ]
Hudson commented on HADOOP-8749:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #2695 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2695/])
HADOOP-8749. HADOOP-8031 changed the way in which relative xincludes are handled in Configuration. (ahmed via tucu) (Revision 1381703)
Result = SUCCESS
tucu : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1381703
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Fix For: 2.2.0-alpha
>
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch, HADOOP-8749_rev3.patch, HADOOP-8749_rev4.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8749) HADOOP-8031 changed the way in which
relative xincludes are handled in Configuration.
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated HADOOP-8749:
---------------------------------
Attachment: HADOOP-8749.patch
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: HADOOP-8749.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in
which relative xincludes are handled in Configuration.
Posted by "Steve Loughran (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446657#comment-13446657 ]
Steve Loughran commented on HADOOP-8749:
----------------------------------------
any proposed patch ought to handle the case where the XML parser doesn't support XInclude; that's broken things before
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: HADOOP-8749.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-8749) HADOOP-8031 changed the way in which
relative xincludes are handled in Configuration.
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ahmed Radwan updated HADOOP-8749:
---------------------------------
Attachment: HADOOP-8749_rev3.patch
I missed adding the tmp directory creation to the previous patch (I had it locally and this is why it was successfully running). Here is the updated patch. The TestZKFailoverController failures seems unrelated (see HADOOP-8591).
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: HADOOP-8749.patch, HADOOP-8749_rev2.patch, HADOOP-8749_rev3.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-8749) HADOOP-8031 changed the way in
which relative xincludes are handled in Configuration.
Posted by "Ahmed Radwan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-8749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445200#comment-13445200 ]
Ahmed Radwan commented on HADOOP-8749:
--------------------------------------
I'll be adding a test case.
> HADOOP-8031 changed the way in which relative xincludes are handled in Configuration.
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-8749
> URL: https://issues.apache.org/jira/browse/HADOOP-8749
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Reporter: Ahmed Radwan
> Assignee: Ahmed Radwan
> Attachments: HADOOP-8749.patch
>
>
> The patch from HADOOP-8031 changed the xml parsing to use DocumentBuilder#parse(InputStream uri.openStream()) instead of DocumentBuilder#parse(String uri.toString()).I looked into the implementation of javax.xml.parsers.DocumentBuilder and org.xml.sax.InputSource and there is a difference when the DocumentBuilder parse(String) method is used versus parse(InputStream).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira