You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by shen guoquan <gu...@intel.com> on 2015/03/05 03:38:20 UTC
Re: Review Request 31658: SENTRY-661: Ensure Sqoop Sentry
authorizaiton works with sentry service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31658/
-----------------------------------------------------------
(Updated 三月 5, 2015, 2:38 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Ensure Sqoop Sentry authorizaiton works with sentry service
Diffs
-----
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopProviderBackend.java PRE-CREATION
sentry-provider/sentry-provider-db/pom.xml 6116cd5
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java dab7d74
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java d6600a0
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java PRE-CREATION
Diff: https://reviews.apache.org/r/31658/diff/
Testing
-------
Thanks,
shen guoquan
Re: Review Request 31658: SENTRY-661: Ensure Sqoop Sentry
authorizaiton works with sentry service
Posted by shen guoquan <gu...@intel.com>.
> On 四月 1, 2015, 1:22 a.m., Prasad Mujumdar wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java, line 18
> > <https://reviews.apache.org/r/31658/diff/1/?file=882584#file882584line18>
> >
> > ok. In that case should we create a new package ? IMO the thrift package is suppose to be for RPC related classes.
Yeah, I will create a new package, thanks prasad for your advice. Thanks very much.
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31658/#review78461
-----------------------------------------------------------
On 三月 5, 2015, 2:38 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31658/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2015, 2:38 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Ensure Sqoop Sentry authorizaiton works with sentry service
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopProviderBackend.java PRE-CREATION
> sentry-provider/sentry-provider-db/pom.xml 6116cd5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java dab7d74
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java d6600a0
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31658/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31658: SENTRY-661: Ensure Sqoop Sentry
authorizaiton works with sentry service
Posted by shen guoquan <gu...@intel.com>.
> On 四月 1, 2015, 1:22 a.m., Prasad Mujumdar wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java, line 18
> > <https://reviews.apache.org/r/31658/diff/1/?file=882584#file882584line18>
> >
> > ok. In that case should we create a new package ? IMO the thrift package is suppose to be for RPC related classes.
Yeah, I will create a new package, thanks prasad for your advice. Thanks very much.
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31658/#review78461
-----------------------------------------------------------
On 三月 5, 2015, 2:38 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31658/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2015, 2:38 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Ensure Sqoop Sentry authorizaiton works with sentry service
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopProviderBackend.java PRE-CREATION
> sentry-provider/sentry-provider-db/pom.xml 6116cd5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java dab7d74
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java d6600a0
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31658/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31658: SENTRY-661: Ensure Sqoop Sentry
authorizaiton works with sentry service
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31658/#review78461
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java
<https://reviews.apache.org/r/31658/#comment127212>
ok. In that case should we create a new package ? IMO the thrift package is suppose to be for RPC related classes.
- Prasad Mujumdar
On March 5, 2015, 2:38 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31658/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 2:38 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Ensure Sqoop Sentry authorizaiton works with sentry service
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopProviderBackend.java PRE-CREATION
> sentry-provider/sentry-provider-db/pom.xml 6116cd5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java dab7d74
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java d6600a0
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31658/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31658: SENTRY-661: Ensure Sqoop Sentry
authorizaiton works with sentry service
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31658/#review80395
-----------------------------------------------------------
Ship it!
- Prasad Mujumdar
On April 7, 2015, 3:41 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31658/
> -----------------------------------------------------------
>
> (Updated April 7, 2015, 3:41 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Ensure Sqoop Sentry authorizaiton works with sentry service
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopProviderBackend.java PRE-CREATION
> sentry-provider/sentry-provider-db/pom.xml 9c2fc81
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java daeefdf
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java d6600a0
>
> Diff: https://reviews.apache.org/r/31658/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31658: SENTRY-661: Ensure Sqoop Sentry
authorizaiton works with sentry service
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31658/#review80395
-----------------------------------------------------------
Ship it!
- Prasad Mujumdar
On April 7, 2015, 3:41 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31658/
> -----------------------------------------------------------
>
> (Updated April 7, 2015, 3:41 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Ensure Sqoop Sentry authorizaiton works with sentry service
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopProviderBackend.java PRE-CREATION
> sentry-provider/sentry-provider-db/pom.xml 9c2fc81
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java PRE-CREATION
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java daeefdf
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java d6600a0
>
> Diff: https://reviews.apache.org/r/31658/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31658: SENTRY-661: Ensure Sqoop Sentry
authorizaiton works with sentry service
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31658/
-----------------------------------------------------------
(Updated 四月 7, 2015, 3:41 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Ensure Sqoop Sentry authorizaiton works with sentry service
Diffs (updated)
-----
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopProviderBackend.java PRE-CREATION
sentry-provider/sentry-provider-db/pom.xml 9c2fc81
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java daeefdf
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java d6600a0
Diff: https://reviews.apache.org/r/31658/diff/
Testing
-------
Thanks,
shen guoquan
Re: Review Request 31658: SENTRY-661: Ensure Sqoop Sentry
authorizaiton works with sentry service
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31658/#review78461
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java
<https://reviews.apache.org/r/31658/#comment127212>
ok. In that case should we create a new package ? IMO the thrift package is suppose to be for RPC related classes.
- Prasad Mujumdar
On March 5, 2015, 2:38 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31658/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 2:38 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Ensure Sqoop Sentry authorizaiton works with sentry service
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopProviderBackend.java PRE-CREATION
> sentry-provider/sentry-provider-db/pom.xml 6116cd5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java dab7d74
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java d6600a0
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31658/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31658: SENTRY-661: Ensure Sqoop Sentry
authorizaiton works with sentry service
Posted by shen guoquan <gu...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31658/
-----------------------------------------------------------
(Updated 四月 7, 2015, 3:41 a.m.)
Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
Repository: sentry
Description
-------
Ensure Sqoop Sentry authorizaiton works with sentry service
Diffs (updated)
-----
sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopProviderBackend.java PRE-CREATION
sentry-provider/sentry-provider-db/pom.xml 9c2fc81
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/SentryGenericProviderBackend.java PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java daeefdf
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java d6600a0
Diff: https://reviews.apache.org/r/31658/diff/
Testing
-------
Thanks,
shen guoquan
Re: Review Request 31658: SENTRY-661: Ensure Sqoop Sentry
authorizaiton works with sentry service
Posted by shen guoquan <gu...@intel.com>.
> On 三月 21, 2015, 5:25 p.m., Prasad Mujumdar wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java, line 18
> > <https://reviews.apache.org/r/31658/diff/1/?file=882584#file882584line18>
> >
> > Should this be in sentry.provider.db package ?
Hi,Prasad. This class SentryGenericProviderBackend is the super class for all kinds of component which wanted to integration with db providerbackend. It is the same as the SentryGenericServiceClient. So I think the sentry.provider.db is a prefer place for this class. What do you think? I am waiting for your idea. Thanks:)
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31658/#review77343
-----------------------------------------------------------
On 三月 5, 2015, 2:38 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31658/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2015, 2:38 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Ensure Sqoop Sentry authorizaiton works with sentry service
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopProviderBackend.java PRE-CREATION
> sentry-provider/sentry-provider-db/pom.xml 6116cd5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java dab7d74
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java d6600a0
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31658/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31658: SENTRY-661: Ensure Sqoop Sentry
authorizaiton works with sentry service
Posted by shen guoquan <gu...@intel.com>.
> On 三月 21, 2015, 5:25 p.m., Prasad Mujumdar wrote:
> > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java, line 18
> > <https://reviews.apache.org/r/31658/diff/1/?file=882584#file882584line18>
> >
> > Should this be in sentry.provider.db package ?
Hi,Prasad. This class SentryGenericProviderBackend is the super class for all kinds of component which wanted to integration with db providerbackend. It is the same as the SentryGenericServiceClient. So I think the sentry.provider.db is a prefer place for this class. What do you think? I am waiting for your idea. Thanks:)
- shen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31658/#review77343
-----------------------------------------------------------
On 三月 5, 2015, 2:38 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31658/
> -----------------------------------------------------------
>
> (Updated 三月 5, 2015, 2:38 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Ensure Sqoop Sentry authorizaiton works with sentry service
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopProviderBackend.java PRE-CREATION
> sentry-provider/sentry-provider-db/pom.xml 6116cd5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java dab7d74
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java d6600a0
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31658/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31658: SENTRY-661: Ensure Sqoop Sentry
authorizaiton works with sentry service
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31658/#review77343
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java
<https://reviews.apache.org/r/31658/#comment125253>
Should this be in sentry.provider.db package ?
- Prasad Mujumdar
On March 5, 2015, 2:38 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31658/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 2:38 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Ensure Sqoop Sentry authorizaiton works with sentry service
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopProviderBackend.java PRE-CREATION
> sentry-provider/sentry-provider-db/pom.xml 6116cd5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java dab7d74
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java d6600a0
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31658/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>
Re: Review Request 31658: SENTRY-661: Ensure Sqoop Sentry
authorizaiton works with sentry service
Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31658/#review77343
-----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java
<https://reviews.apache.org/r/31658/#comment125253>
Should this be in sentry.provider.db package ?
- Prasad Mujumdar
On March 5, 2015, 2:38 a.m., shen guoquan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31658/
> -----------------------------------------------------------
>
> (Updated March 5, 2015, 2:38 a.m.)
>
>
> Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, Dapeng Sun, and Prasad Mujumdar.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Ensure Sqoop Sentry authorizaiton works with sentry service
>
>
> Diffs
> -----
>
> sentry-binding/sentry-binding-sqoop/src/main/java/org/apache/sentry/sqoop/binding/SqoopProviderBackend.java PRE-CREATION
> sentry-provider/sentry-provider-db/pom.xml 6116cd5
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java dab7d74
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java d6600a0
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericProviderBackend.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31658/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> shen guoquan
>
>