You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/12 08:46:05 UTC

[GitHub] [flink] rkhachatryan opened a new pull request #10542: [FLINK-12484][runtime] move checkpoint lock to source task

rkhachatryan opened a new pull request #10542: [FLINK-12484][runtime] move checkpoint lock to source task
URL: https://github.com/apache/flink/pull/10542
 
 
   ## What is the purpose of the change
   
   **This PR is WIP**
   
   This PR removes usages of the `StreamTask#getCheckpointLock()` method and moves the field to `SourceStreamTask`.
   Checkpoint lock acquisition in "network" tasks (not source/sink) is unnecessary after moving them to the mailbox execution model.
   
   
   This PR depends on the removal of the checkpoint lock usage from `ContinuousFileReaderOperator` (#10435).
   
   ## Brief change log
   
     - *remove usages of the `StreamTask#getCheckpointLock()` method *
     - *use `IMMEDIATE` (no-op) `StreamTaskActionExecutor` (decorator) in `StreamTask` by default*
     - *move the actual checkpoint lock object (field) to `SourceStreamTask` and use `SynchronizedStreamTaskActionExecutor` in it*
     - *remove testing of checkpoint lock acquisition*
     - *update other tests 
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): yes (removes lock acquisition for mails in network tasks which may be per record)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services