[jira] [Commented] (BCEL-183) Implement Java 7 field/method name validation rules

["Sarah Murray (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BCEL-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14351194#comment-14351194 ] 

Sarah Murray commented on BCEL-183:
-----------------------------------

[~jejecool], [Mark Thomas said on the mailing list that the following would help him commit this code|http://markmail.org/search/?q=list%3Aorg.apache.commons.dev/#query:list%3Aorg.apache.commons.dev%2F+page:1+mid:lvm5vrr52mxgrikp+state:results]

It is not at all clear how much of the original issue (if any) was fixed by the change reported 19-Dec-2014.

The potential for the required behaviour to vary with class file version is a complicating factor.

This issues seems to be bundling up a number of smaller issues. That makes it harder to work with even if they are all in the same area.

Generally for all of these issues some pointers to the relevant parts of the JVM spec - preferably as comments in the patch - would make it easier for folks to review the patches and easier for future maintainers to understand what the code is doing.

Also generally, it looks like a number of the patches could be reduced in size by pulling out the common testing framework.

> Implement Java 7 field/method name validation rules
> ---------------------------------------------------
>
>                 Key: BCEL-183
>                 URL: https://issues.apache.org/jira/browse/BCEL-183
>             Project: Commons BCEL
>          Issue Type: Improvement
>          Components: Verifier
>    Affects Versions: 5.2
>            Reporter: Jérôme Leroux
>             Fix For: 6.0
>
>         Attachments: BCEL-183-2.patch, BCEL-183-2.zip, BCEL-183-src.zip, BCEL-183.patch, BCEL-183.zip
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The JustIce bytecode verifier checks the validity of the field name and the variable name considering the java langage specification. 
> This check is not specified by the bytecode verifier specification.
> This may lead to bytecode verification errors in pass2 on valid classfiles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)