You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "cmccabe (via GitHub)" <gi...@apache.org> on 2024/03/22 20:19:33 UTC
[PR] MINOR: ensure LocalLogManagerTestEnv is closed in QuorumControllerTest [kafka]
cmccabe opened a new pull request, #15582:
URL: https://github.com/apache/kafka/pull/15582
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: ensure LocalLogManagerTestEnv is closed in QuorumControllerTest [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #15582: MINOR: ensure LocalLogManagerTestEnv is closed in QuorumControllerTest
URL: https://github.com/apache/kafka/pull/15582
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: ensure LocalLogManagerTestEnv is closed in QuorumControllerTest [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15582:
URL: https://github.com/apache/kafka/pull/15582#issuecomment-2571488578
This PR is being marked as stale since it has not had any activity in 90 days. If you
would like to keep this PR alive, please leave a comment asking for a review. If the PR has
merge conflicts, update it with the latest from the base branch.
<p>
If you are having difficulty finding a reviewer, please reach out on the
[mailing list](https://kafka.apache.org/contact).
<p>
If this PR is no longer valid or desired, please feel free to close it. If no activity
occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: ensure LocalLogManagerTestEnv is closed in QuorumControllerTest [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #15582:
URL: https://github.com/apache/kafka/pull/15582#discussion_r1536587476
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -1540,15 +1540,14 @@ public void testActivationRecordsPartialBootstrap(boolean zkMigrationEnabled) {
@Test
public void testMigrationsEnabledForOldBootstrapMetadataVersion() throws Exception {
try (
- LocalLogManagerTestEnv logEnv = new LocalLogManagerTestEnv.Builder(1).build()
+ LocalLogManagerTestEnv logEnv = new LocalLogManagerTestEnv.Builder(1).build();
) {
- QuorumControllerTestEnv.Builder controlEnvBuilder = new QuorumControllerTestEnv.Builder(logEnv).
- setControllerBuilderInitializer(controllerBuilder -> {
- controllerBuilder.setZkMigrationEnabled(true);
- }).
- setBootstrapMetadata(BootstrapMetadata.fromVersion(MetadataVersion.IBP_3_3_IV0, "test"));
-
- QuorumControllerTestEnv controlEnv = controlEnvBuilder.build();
+ QuorumControllerTestEnv controlEnv = new QuorumControllerTestEnv.Builder(logEnv).
Review Comment:
Should we ensure `QuorumControllerTestEnv` is closed also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: ensure LocalLogManagerTestEnv is closed in QuorumControllerTest [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #15582:
URL: https://github.com/apache/kafka/pull/15582#issuecomment-2635628744
This PR has been closed since it has not had any activity in 120 days. If you feel like this
was a mistake, or you would like to continue working on it, please feel free to re-open the
PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: ensure LocalLogManagerTestEnv is closed in QuorumControllerTest [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #15582:
URL: https://github.com/apache/kafka/pull/15582#discussion_r1536587007
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -1540,15 +1540,14 @@ public void testActivationRecordsPartialBootstrap(boolean zkMigrationEnabled) {
@Test
public void testMigrationsEnabledForOldBootstrapMetadataVersion() throws Exception {
try (
- LocalLogManagerTestEnv logEnv = new LocalLogManagerTestEnv.Builder(1).build()
+ LocalLogManagerTestEnv logEnv = new LocalLogManagerTestEnv.Builder(1).build();
) {
- QuorumControllerTestEnv.Builder controlEnvBuilder = new QuorumControllerTestEnv.Builder(logEnv).
- setControllerBuilderInitializer(controllerBuilder -> {
- controllerBuilder.setZkMigrationEnabled(true);
- }).
- setBootstrapMetadata(BootstrapMetadata.fromVersion(MetadataVersion.IBP_3_3_IV0, "test"));
-
- QuorumControllerTestEnv controlEnv = controlEnvBuilder.build();
+ QuorumControllerTestEnv controlEnv = new QuorumControllerTestEnv.Builder(logEnv).
+ setControllerBuilderInitializer(controllerBuilder -> {
+ controllerBuilder.setZkMigrationEnabled(true);
+ }).
+ setBootstrapMetadata(BootstrapMetadata.fromVersion(MetadataVersion.IBP_3_3_IV0, "test")).
+ build();
Review Comment:
`;` is unnecessary
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -1540,15 +1540,14 @@ public void testActivationRecordsPartialBootstrap(boolean zkMigrationEnabled) {
@Test
public void testMigrationsEnabledForOldBootstrapMetadataVersion() throws Exception {
try (
- LocalLogManagerTestEnv logEnv = new LocalLogManagerTestEnv.Builder(1).build()
+ LocalLogManagerTestEnv logEnv = new LocalLogManagerTestEnv.Builder(1).build();
) {
- QuorumControllerTestEnv.Builder controlEnvBuilder = new QuorumControllerTestEnv.Builder(logEnv).
- setControllerBuilderInitializer(controllerBuilder -> {
- controllerBuilder.setZkMigrationEnabled(true);
- }).
- setBootstrapMetadata(BootstrapMetadata.fromVersion(MetadataVersion.IBP_3_3_IV0, "test"));
-
- QuorumControllerTestEnv controlEnv = controlEnvBuilder.build();
+ QuorumControllerTestEnv controlEnv = new QuorumControllerTestEnv.Builder(logEnv).
+ setControllerBuilderInitializer(controllerBuilder -> {
Review Comment:
the `{` can be omitted
##########
metadata/src/test/java/org/apache/kafka/controller/QuorumControllerTest.java:
##########
@@ -1658,12 +1657,12 @@ public void testActivationRecordsPartialTransactionNoSupport() {
@Test
public void testFailoverDuringMigrationTransaction() throws Exception {
try (
- LocalLogManagerTestEnv logEnv = new LocalLogManagerTestEnv.Builder(3).build()
- ) {
- QuorumControllerTestEnv.Builder controlEnvBuilder = new QuorumControllerTestEnv.Builder(logEnv).
+ LocalLogManagerTestEnv logEnv = new LocalLogManagerTestEnv.Builder(3).build();
+ QuorumControllerTestEnv controlEnv = new QuorumControllerTestEnv.Builder(logEnv).
setControllerBuilderInitializer(controllerBuilder -> controllerBuilder.setZkMigrationEnabled(true)).
- setBootstrapMetadata(BootstrapMetadata.fromVersion(MetadataVersion.IBP_3_6_IV1, "test"));
- QuorumControllerTestEnv controlEnv = controlEnvBuilder.build();
+ setBootstrapMetadata(BootstrapMetadata.fromVersion(MetadataVersion.IBP_3_6_IV1, "test")).
+ build();
Review Comment:
`;` is unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org