You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/12/02 13:52:57 UTC
[GitHub] [camel-k] squakez opened a new pull request, #3874: fix(e2e): use generated API methods
squakez opened a new pull request, #3874:
URL: https://github.com/apache/camel-k/pull/3874
Closes #3818
<!-- Description -->
<!--
Enter your extended release note in the below block. If the PR requires
additional action from users switching to the new release, include the string
"action required". If no release note is required, write "NONE".
You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
the text is added to the right section of the release notes.
-->
**Release Note**
```release-note
NONE
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3874: fix(e2e): use generated API methods
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3874:
URL: https://github.com/apache/camel-k/pull/3874#issuecomment-1337628367
@phantomjinx, I had a further look and it seems that the "patch" scenario is already tested in https://github.com/apache/camel-k/blob/a82e464d3cea2b28a2068deb30dea35c5f394e76/e2e/global/common/scale_integration_test.go#L73
I've tried to enable the `// +genclient:method=PatchScale,verb=get,subresource=patch,result=k8s.io/api/autoscaling/v1.Scale` but the generation is failing. Looking further on the test, it seems that the original goal of this test was to really test the getter and the setter of the autogenerated Integration Scale client. Is this correct @astefanutti? so, if it keeps failing we should find the reason why the autogenerated code is broken IMO.
Are you okey on reverting these changes? what was the "well known" behavior you were trying to fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on pull request #3874: fix(e2e): use generated API methods
Posted by GitBox <gi...@apache.org>.
astefanutti commented on PR #3874:
URL: https://github.com/apache/camel-k/pull/3874#issuecomment-1337802615
It should ideally be possible to patch the integration scale sub-resource via the generated client and find the right syntax to have the corresponding method generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez merged pull request #3874: fix(e2e): use generated API methods
Posted by GitBox <gi...@apache.org>.
squakez merged PR #3874:
URL: https://github.com/apache/camel-k/pull/3874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3874: fix(e2e): use generated API methods
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3874:
URL: https://github.com/apache/camel-k/pull/3874#issuecomment-1340679343
I need to merge this as it is blocking #3837 (the release process run a `make generate` that wipe off those funcs added manually there). We may want to keep discussing about this though to see how to apply those changes in an autogenerated fashion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on pull request #3874: fix(e2e): use generated API methods
Posted by GitBox <gi...@apache.org>.
squakez commented on PR #3874:
URL: https://github.com/apache/camel-k/pull/3874#issuecomment-1340491802
> It should ideally be possible to patch the integration scale sub-resource via the generated client and find the right syntax to have the corresponding method generated.
Yeah, it was the first thing I tried, but it fails with:
```
./script/gen_client.sh
Generating Go client code...
F1207 08:04:39.322604 40897 main.go:62] Error: Failed executing generator: some packages had errors:
template: /home/squake/go/pkg/mod/k8s.io/code-generator@v0.23.5/cmd/client-gen/generators/generator_for_type.go:200:1:99: executing "/home/squake/go/pkg/mod/k8s.io/code-generator@v0.23.5/cmd/client-gen/generators/generator_for_type.go:200" at <raw>: error calling raw: runtime error: invalid memory address or nil pointer dereference
goroutine 1 [running]:
k8s.io/klog/v2.stacks(0x1)
/home/squake/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:1038 +0x8a
k8s.io/klog/v2.(*loggingT).output(0xa20500, 0x3, 0x0, 0xc007799880, 0x0, {0x889a36, 0x1}, 0xc00717eb00, 0x0)
/home/squake/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:987 +0x5fd
k8s.io/klog/v2.(*loggingT).printf(0x6, 0x7ad830, 0x0, {0x0, 0x0}, {0x77642a, 0x9}, {0xc00717eb00, 0x1, 0x1})
/home/squake/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:753 +0x1c5
k8s.io/klog/v2.Fatalf(...)
/home/squake/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:1532
main.main()
/home/squake/go/pkg/mod/k8s.io/code-generator@v0.23.5/cmd/client-gen/main.go:62 +0x307
goroutine 19 [chan receive]:
k8s.io/klog/v2.(*loggingT).flushDaemon(0x0)
/home/squake/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:1181 +0x6a
created by k8s.io/klog/v2.init.0
/home/squake/go/pkg/mod/k8s.io/klog/v2@v2.30.0/klog.go:420 +0xfb
```
In any case, in theory, the update **should** be reliable, and in the test it seems it works correctly. For this reason I was trying to understand how to correctly leverage the autogenerated code for this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org