[jira] Issue Comment Edited: (THRIFT-750) C++ Compiler Virtual Function Option

["Tim Wilson-Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852737#action_12852737 ] 

Tim Wilson-Brown edited comment on THRIFT-750 at 4/2/10 7:24 AM:
-----------------------------------------------------------------

Edit: this patch was broken

      was (Author: twilsonb):
    Patch for this issue against thrift-0.2.0.

I can provide a patch for HEAD if needed, but it may take me a while
  
> C++ Compiler Virtual Function Option
> ------------------------------------
>
>                 Key: THRIFT-750
>                 URL: https://issues.apache.org/jira/browse/THRIFT-750
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Compiler (C++)
>    Affects Versions: 0.2, 0.3
>         Environment: Cygwin 1.7.1 on Windows XP SP3, Thrift 0.2.0 & r760184 & Trunk 
>            Reporter: Tim Wilson-Brown
>            Priority: Minor
>         Attachments: cpp_virtual_thrift020.patch, t_cpp_generator.cc
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The C++ Compiler currelty emits most functions in the *Client class as non-virtual.
> This makes it difficult to subclass the generated *Client class and override its functions.
> In particular, if a subclass overrides the *_send and *_recv functions, it must also override the function itself.
> Otherwise, the *Client version of the function calls the *Client versions of *_send and *_recv.
> A workaround is to inherit from the interface class *If, which has virtual functions, 
> and use them to call *Client class member functions.
> But this can be cumbersome in some situations, and still requires additional functions to be overridden.
> I propose to add a virtual option to the C++ compiler that emits function declarations as virtual.
> I have attached a patched version of t_cpp_generator.cc from Thrift 0.2.0 - I can work out how to turn it into a patch file if needed.
> Is this worth merging into the trunk?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.