You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/08/18 11:01:48 UTC
[GitHub] [camel-quarkus] aldettinger opened a new pull request, #4013: perf-regression: collect reports during releases #3967
aldettinger opened a new pull request, #4013:
URL: https://github.com/apache/camel-quarkus/pull/4013
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger merged pull request #4013: perf-regression: collect reports during releases #3967
Posted by GitBox <gi...@apache.org>.
aldettinger merged PR #4013:
URL: https://github.com/apache/camel-quarkus/pull/4013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] aldettinger commented on a diff in pull request #4013: perf-regression: collect reports during releases #3967
Posted by GitBox <gi...@apache.org>.
aldettinger commented on code in PR #4013:
URL: https://github.com/apache/camel-quarkus/pull/4013#discussion_r949216839
##########
docs/modules/ROOT/pages/contributor-guide/release-guide.adoc:
##########
@@ -67,6 +67,49 @@ $ mvn deploy -Papache-release -DskipTests -Denforcer.skip -Dquarkus.build.skip -
* This will close the repository from future deployments and make it available for others to view
* After that, a popup window is created, enter the name and version of the artifact being released in the `Description` field and finally click `Close`
+== Collect the performance regression report
+
+Once the staging repository has been closed, run the `perf-regression` tool in order to compare the current staging against the previous released version.
+
+It's important that the machine running the `perf-regression` tool be equally loaded during the run.
+The simplest way would be to take a 1 hour slot at the end of the day, launch the tool on your main station and then lock the screen.
+
+For instance, running the tool to compare the `2.10.0` staging release against the `2.9.0` previous release would look as below:
+
+[source,shell]
+----
+$ cd tooling/perf-regression
+$ java -jar target/quarkus-app/quarkus-run.jar -an 2.9.0 2.10.0
+----
+
+After approximatively 1 hour, it should generate a report like beneath:
Review Comment:
Subtle, so beneath is more a preposition. Many thanks for reporting :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #4013: perf-regression: collect reports during releases #3967
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on code in PR #4013:
URL: https://github.com/apache/camel-quarkus/pull/4013#discussion_r949140037
##########
docs/modules/ROOT/pages/contributor-guide/release-guide.adoc:
##########
@@ -67,6 +67,49 @@ $ mvn deploy -Papache-release -DskipTests -Denforcer.skip -Dquarkus.build.skip -
* This will close the repository from future deployments and make it available for others to view
* After that, a popup window is created, enter the name and version of the artifact being released in the `Description` field and finally click `Close`
+== Collect the performance regression report
+
+Once the staging repository has been closed, run the `perf-regression` tool in order to compare the current staging against the previous released version.
+
+It's important that the machine running the `perf-regression` tool be equally loaded during the run.
+The simplest way would be to take a 1 hour slot at the end of the day, launch the tool on your main station and then lock the screen.
+
+For instance, running the tool to compare the `2.10.0` staging release against the `2.9.0` previous release would look as below:
+
+[source,shell]
+----
+$ cd tooling/perf-regression
+$ java -jar target/quarkus-app/quarkus-run.jar -an 2.9.0 2.10.0
+----
+
+After approximatively 1 hour, it should generate a report like beneath:
Review Comment:
Nitpick:
```suggestion
After approximatively 1 hour, it should generate a report like below:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org