You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Erick Erickson (JIRA)" <ji...@apache.org> on 2013/11/21 14:49:36 UTC
[jira] [Commented] (SOLR-5316) Solr 4.2.1 LotsOfCores new options
[ https://issues.apache.org/jira/browse/SOLR-5316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828951#comment-13828951 ]
Erick Erickson commented on SOLR-5316:
--------------------------------------
olivier:
Sorry it took so long for me to get to this, it's been a busy month.
1> I can't apply the patch successfully to current code. Quite a bit changed between 4.2 and even 4.4. Could you make this patch work against a current version of Solr? In particular, much of the persistence code is different, especially since we're preparing to deprecate defining cores in solr.xml and going toward auto-discovery mode.
2> Please use the standard Java camelcase naming conventions, e..g 'Auto' should be 'auto'
3> The convention is to just name the patch for the JIRA, i.e. SOLR-5316.patch. Upload subsequent patches with the same name, newer ones will appear in blue and older ones in gray. That makes it easy to know which one is most recent.
4> There are tabs in the code, the convention is 2 spaces. There are configuration files for Eclipse and IntelliJ, along with instructions on how to add them to your environment here: http://wiki.apache.org/solr/HowToContribute#Development_Environment_Tips
Try running "ant precommit" after the changes, that'll point out things like tabs etc.
Thanks!
> Solr 4.2.1 LotsOfCores new options
> ----------------------------------
>
> Key: SOLR-5316
> URL: https://issues.apache.org/jira/browse/SOLR-5316
> Project: Solr
> Issue Type: Improvement
> Components: multicore
> Affects Versions: 4.2.1
> Reporter: olivier soyez
> Assignee: Erick Erickson
> Priority: Minor
> Labels: patch
> Fix For: 4.2.1
>
> Attachments: solr-4.2.1.patchLOTSOFCORES
>
>
> This patch is for the lotsofcores use case, including some modification :
> - by default, all cores have loadOnStartup="false" and transient="true" attributes
> - the create admin command can register a lazy core (to take into account the transientCacheSize option)
> - add transient cores persistency
> - handle unload admin command for never launched transient cores (non active cores)
> To improve performance, we use this Solr patched version with the persistence disabled.
> In this way, Solr is working with a solr.xml file without any core entries, because it's useless in our use case (with the new Auto option for the cores)
> The new Cores options :
> - "numBuckets" to create a subdirectory based on a hash on the corename
> % numBuckets in the core Datadir, because all cores cannot live in the
> same directory
> - "Auto" with 3 differents values :
> 1) false : default behaviour
> 2) createLoad : create, if not exist, and load the core on the fly on
> the first incoming request (update, select).
> 3) onlyLoad : load the core on the fly on the first incoming request
> (update, select), if exist on disk
> The Auto option uses an additional cores option named baseDataDir to automatically generate the dataDir of each core and uses the "numBucket" option if exists.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org