You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/04/19 03:38:22 UTC
[GitHub] [kafka] showuon opened a new pull request #10559: MINOR: diable RaftClusterTest first
showuon opened a new pull request #10559:
URL: https://github.com/apache/kafka/pull/10559
Disable the flaky RaftClusterTest tests before the root cause KAFKA-12677 got fixed.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on pull request #10559: MINOR: diable RaftClusterTest first
Posted by GitBox <gi...@apache.org>.
jsancio commented on pull request #10559:
URL: https://github.com/apache/kafka/pull/10559#issuecomment-822658214
@showuon Do we need to disable the entire suite of tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman edited a comment on pull request #10559: MINOR: diable RaftClusterTest first
Posted by GitBox <gi...@apache.org>.
ableegoldman edited a comment on pull request #10559:
URL: https://github.com/apache/kafka/pull/10559#issuecomment-829797388
Do we really need to disable them or is there a fix in the works? I'm fine with disabling so long as someone is actively looking into this, but given this is such a critical and complex new feature we should take these test failures very seriously. It's not been apparent to me that we are, but I'm not actively involved in the KIP-500 stuff so I wouldn't be surprised if it's just taking so long because it's hard 🙂
Anyways can @cmccabe or @hachikuji or @jsancio or @ijuma or anyone else from the KIP-500 world comment on this? These tests are failing on pretty much every single PR I've seen lately, often with multiple failures per build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10559: MINOR: diable RaftClusterTest first
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10559:
URL: https://github.com/apache/kafka/pull/10559#issuecomment-829797388
Do we really need to disable them or is there a fix in the works? I'm fine with disabling so long as someone is actively looking into this, but given this is such a critical and complex new feature we should take these test failures very seriously. It's not been apparent to me that we are, but I'm not actively involved in the KIP-500 stuff so I wouldn't be surprised if it's just taking so long because it's hard 🙂
Anyways can @cmccabe or @hachikuji or @jsancio or someone else from the KIP-500 world comment on this? These tests are failing on pretty much every single PR I've seen lately, often with multiple failures per build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10559: MINOR: diable RaftClusterTest first
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10559:
URL: https://github.com/apache/kafka/pull/10559#issuecomment-822144126
@cmccabe , I think the root cause might need some time to get fix. Do you think we should disable the tests first? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10559: MINOR: diable RaftClusterTest first
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10559:
URL: https://github.com/apache/kafka/pull/10559#issuecomment-879029730
close this PR since the root cause is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a change in pull request #10559: MINOR: diable RaftClusterTest first
Posted by GitBox <gi...@apache.org>.
showuon commented on a change in pull request #10559:
URL: https://github.com/apache/kafka/pull/10559#discussion_r615524139
##########
File path: core/src/test/scala/integration/kafka/server/RaftClusterTest.scala
##########
@@ -22,14 +22,16 @@ import kafka.utils.TestUtils
import org.apache.kafka.clients.admin.{Admin, NewTopic}
import org.apache.kafka.common.quota.{ClientQuotaAlteration, ClientQuotaEntity, ClientQuotaFilter, ClientQuotaFilterComponent}
import org.apache.kafka.metadata.BrokerState
-import org.junit.jupiter.api.{Test, Timeout}
+import org.junit.jupiter.api.{Disabled, Test, Timeout}
import org.junit.jupiter.api.Assertions._
-
import java.util
import java.util.Collections
+
import scala.jdk.CollectionConverters._
-@Timeout(120000)
Review comment:
The timeout unit is in seconds. Fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on pull request #10559: MINOR: diable RaftClusterTest first
Posted by GitBox <gi...@apache.org>.
showuon commented on pull request #10559:
URL: https://github.com/apache/kafka/pull/10559#issuecomment-822883918
@jsancio , good question. I just checked the recent 10 trunk builds, and found that there are only 3 tests flaky. So, I updated to only disable 3 tests. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon closed pull request #10559: MINOR: diable RaftClusterTest first
Posted by GitBox <gi...@apache.org>.
showuon closed pull request #10559:
URL: https://github.com/apache/kafka/pull/10559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #10559: MINOR: diable RaftClusterTest first
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #10559:
URL: https://github.com/apache/kafka/pull/10559#issuecomment-822496169
cc @jsancio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org