[GitHub] [spark] Ngone51 commented on a diff in pull request #37268: [SPARK-39853][CORE] Support stage level task resource schedule for standalone cluster when dynamic allocation disabled

[GitBox <gi...@apache.org>]

Ngone51 commented on code in PR #37268:
URL: https://github.com/apache/spark/pull/37268#discussion_r934217812


##########
core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala:
##########
@@ -253,6 +265,32 @@ class ResourceProfile(
   }
 }
 
+/**
+ * Resource profile which only contains task resources, used for stage level task schedule when
+ * dynamic allocation is disabled, tasks will be scheduled to executors with default resource
+ * profile based on task resources described by this task resource profile.
+ *
+ * @param taskResources Resource requests for tasks. Mapped from the resource
+ *                      name (e.g., cores, memory, CPU) to its specific request.
+ */
+@Evolving
+@Since("3.4.0")
+class TaskResourceProfile(override val taskResources: Map[String, TaskResourceRequest])
+  extends ResourceProfile(Map.empty, taskResources) {

Review Comment:
   How about:
   ```suggestion
     extends ResourceProfile(ResourceProfile.getOrCreateDefaultProfile(SparkEnv.get.conf).executorResources, taskResources) {
   ```
   so we don't need to override `getTargetCustomExecutorResources()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org