You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/17 21:00:40 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #898: Fix #897
List the JVM-only extensions in the docs
ppalaga opened a new pull request #898: Fix #897 List the JVM-only extensions in the docs
URL: https://github.com/apache/camel-quarkus/pull/898
Fix #897
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #898: Fix #897 List the
JVM-only extensions in the docs
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #898: Fix #897 List the JVM-only extensions in the docs
URL: https://github.com/apache/camel-quarkus/pull/898#issuecomment-600873844
0f9eef7 fixed the create mojo config
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #898: Fix #897 List the
JVM-only extensions in the docs
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #898: Fix #897 List the JVM-only extensions in the docs
URL: https://github.com/apache/camel-quarkus/pull/898#issuecomment-600515447
> We should not move the functionalities of the package-maven-plugin outside of the camel-quarkus repository as it will introduces yet another external dependency not under direct control of Apache Camel commiters.
It is true that not every Apache Camel committer has access, but OTOH, there are more than one Apache Camel committer that do have write access there.
The motivation was threefold:
* The packaging mojos share some code with the create-extension and code formatting mojos.
* Having a plugin hosted in the same source tree where it is applied, is not ideal from the built performance PoV.
* When the mojos are hosted in a separate repo, they can be run without building them first, which makes the process easier esp. for the newcomers.
Moving the mojos to a separate repo under the ASF umbrella would mean loosing the flexibility of releasing on demand. My understanding is that the voting process cannot be relaxed even for tools like these, right?
So if you insist on your veto, I am going to move the changes back to camel-quarkus.
> In addition it creates a dependency issue as to update to a new version of Apache Camel would require to update the plugin first.
This is not an issue, as long as camel-catalog stays backwards compatible, because it is managed on the Camel Quarkus side https://github.com/apache/camel-quarkus/pull/898/files#diff-600376dffeb79835ede4a0b285078036R239-R243
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #898: Fix #897 List the
JVM-only extensions in the docs
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #898: Fix #897 List the JVM-only extensions in the docs
URL: https://github.com/apache/camel-quarkus/pull/898#issuecomment-600762849
00e3c63 brings the mojos back to the Camel Quarkus source tree
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #898: Fix #897 List the
JVM-only extensions in the docs
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #898: Fix #897 List the JVM-only extensions in the docs
URL: https://github.com/apache/camel-quarkus/pull/898#issuecomment-600856184
d93f2be should fix the test failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on issue #898: Fix #897 List
the JVM-only extensions in the docs
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #898: Fix #897 List the JVM-only extensions in the docs
URL: https://github.com/apache/camel-quarkus/pull/898#issuecomment-600518988
I think it is fine to have the extension generator outside the camel-quarkus repo as it is an optional thing but for the catalog generator and other functionalities provided by the package maven plugin it would be bad move so IMHO we should be keep it as part of the camel-quarkus repo.
@davsclaus @gnodet @oscerd what don you think ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] davsclaus commented on issue #898: Fix #897 List
the JVM-only extensions in the docs
Posted by GitBox <gi...@apache.org>.
davsclaus commented on issue #898: Fix #897 List the JVM-only extensions in the docs
URL: https://github.com/apache/camel-quarkus/pull/898#issuecomment-600520219
Yes the quarkus camel catalog should be here, this is what we do in other projects too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli edited a comment on issue #898: Fix
#897 List the JVM-only extensions in the docs
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on issue #898: Fix #897 List the JVM-only extensions in the docs
URL: https://github.com/apache/camel-quarkus/pull/898#issuecomment-600518988
I think it is fine to have the extension generator outside the camel-quarkus repo as it is an optional thing but for the catalog generator and other functionalities provided by the package maven plugin it would be a bad move so IMHO we should be keep it as part of the camel-quarkus repo.
@davsclaus @gnodet @oscerd what don you think ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga merged pull request #898: Fix #897 List the
JVM-only extensions in the docs
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #898: Fix #897 List the JVM-only extensions in the docs
URL: https://github.com/apache/camel-quarkus/pull/898
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #898: Fix #897 List the
JVM-only extensions in the docs
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #898: Fix #897 List the JVM-only extensions in the docs
URL: https://github.com/apache/camel-quarkus/pull/898#issuecomment-600469668
e4543eb fixed the license header issues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on issue #898: Fix #897 List the
JVM-only extensions in the docs
Posted by GitBox <gi...@apache.org>.
ppalaga commented on issue #898: Fix #897 List the JVM-only extensions in the docs
URL: https://github.com/apache/camel-quarkus/pull/898#issuecomment-600327779
d51d679 fixed the failing test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services