You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by zhuoliu <gi...@git.apache.org> on 2015/09/29 20:26:26 UTC
[GitHub] storm pull request: [STORM-1066] add current directory for worker ...
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/769
[STORM-1066] add current directory for worker process launcher
Currently, when supervisor launches a worker, the current directory of the worker process is not specified. In that case, the worker will be launched with a current directory as ".", which is a random directory. It can cause problems especially when the worker needs to dump something to its current directory.
To fix this, we should enable ProcessBuilder to specify worker's current directory as worker-root/worker-uuid.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm 1066
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/769.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #769
----
commit 8edf1c28eb82c31969a39041d89b2f0923a3d0f4
Author: zhuol <zh...@yahoo-inc.com>
Date: 2015-09-29T17:49:01Z
[STORM-1066] add current directory for worker process launcher
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1066] add current directory for worker ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/769
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1066] add current directory for worker ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/769#issuecomment-145200478
Since PR contains bugfix which is introduced to 0.10.x-branch, I'll backport this to 0.10.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1066] add current directory for worker ...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/769#issuecomment-144846835
+1 Nice work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1066] add current directory for worker ...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/769#issuecomment-144515204
+1 looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-1066] add current directory for worker ...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/769#issuecomment-145155436
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---