You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/23 01:33:38 UTC

[GitHub] [apisix-website] juzhiyuan opened a new issue #763: combine configuration files into one

juzhiyuan opened a new issue #763:
URL: https://github.com/apache/apisix-website/issues/763


   **Actual Behaviour**
   
   Apache APISIX Website has 2 pages around `apisix-*` repos:
   
   - https://apisix.apache.org/docs
   - https://apisix.apache.org/downloads
   
   Those 2 pages are generated from 2 different configuration files, some contents are the same so we could combine them into one:
   
   - https://github.com/apache/apisix-website/blob/master/website/config/downloads.js
   - https://github.com/apache/apisix-website/blob/master/website/config/docs.js
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Swastyy commented on issue #763: combine configuration files into one

Posted by GitBox <gi...@apache.org>.
Swastyy commented on issue #763:
URL: https://github.com/apache/apisix-website/issues/763#issuecomment-980587948


   > After considering, how about this?
   > 
   > 1. To have a configuration file containing all repos' configuration;
   > 2. To add a property called hiddenOnDocumentList
   > 3. Add a property called latestVersion, latestDownloadLink
   
   I want to work on this, please assign it to me. And what will the hiddenDocumentList do, does it contains some configuration that aren't public or something that is not to be shown in the website?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] juzhiyuan closed issue #763: combine configuration files into one

Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #763:
URL: https://github.com/apache/apisix-website/issues/763


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] juzhiyuan commented on issue #763: combine configuration files into one

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #763:
URL: https://github.com/apache/apisix-website/issues/763#issuecomment-1016009760


   After consideration, I think it will increase complexity, I'm going to close this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] juzhiyuan commented on issue #763: combine configuration files into one

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #763:
URL: https://github.com/apache/apisix-website/issues/763#issuecomment-980515541


   After considering, how about this?
   
   1. To have a configuration file containing all repos' configuration;
   2. To add a property called hiddenOnDocumentList
   3. Add a property called latestVersion, latestDownloadLink


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] Swastyy commented on issue #763: combine configuration files into one

Posted by GitBox <gi...@apache.org>.
Swastyy commented on issue #763:
URL: https://github.com/apache/apisix-website/issues/763#issuecomment-980513130


   Hi @juzhiyuan I see there is a option of Downloads in the `Download` webpage from where a user can directly download whereas its not there in the `Documents` webpage. If you want to combine them then I want to do this. One more thing which one out of `docs.js` and `downloads.js` to keep and which one else to remove?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apisix-website] juzhiyuan commented on issue #763: combine configuration files into one

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #763:
URL: https://github.com/apache/apisix-website/issues/763#issuecomment-981109253


   >  And what will the hiddenDocumentList do, does it contains some configuration that aren't public or something that is not to be shown in the website?
   
   🤔 Yes, you're right, for this case, we don't need that property at all.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org