[GitHub] [cassandra] maxim-chn commented on a diff in pull request #1910: Resolve IP option for Nodetool gossiping command

[GitBox <gi...@apache.org>]

maxim-chn commented on code in PR #1910:
URL: https://github.com/apache/cassandra/pull/1910#discussion_r995981599


##########
src/java/org/apache/cassandra/locator/InetAddressAndPort.java:
##########
@@ -122,6 +122,12 @@ public String getHostAddress(boolean withPort)
         return hostAddress(this, withPort);
     }
 
+    public String getHostName(boolean withPort)
+    {
+        StringBuilder sb = new StringBuilder(getHostName());

Review Comment:
   @smiklosovic,
   I've committed the new return statement at [adb93aa](https://github.com/apache/cassandra/pull/1910/commits/adb93aaa5722e6bd12b0b5e6eaaa864d511049c9) and seen that `InetAddressAndPortTest.java` unit test passed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org