You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tcl.apache.org by mx...@apache.org on 2019/12/09 10:05:25 UTC

[tcl-rivet] branch 3.1 updated (242750b -> e5d9d23)

This is an automated email from the ASF dual-hosted git repository.

mxmanghi pushed a change to branch 3.1
in repository https://gitbox.apache.org/repos/asf/tcl-rivet.git.


    from 242750b  Add Tcl_DecrRefCnt after RivetCache_StoreScript as this function itself calls Tcl_IncrRefCnt to preserve the Tcl_Obj with the script code
     new cec4547  fixed upload example
     new 1ccfa30  Added RivetCache_DeleteEntry function
     new 216ac2b  Fix crash in cache when rvt file is not readable
     new e076a22  merge ChangeLog modifications introduced by Cache Fixup
     new 07af70b  fixed crash when rvt file not readable
     new e5d9d23  New branch version is 3.1.2

The 6 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 ChangeLog                          |  8 ++++++++
 VERSION                            |  2 +-
 doc/examples/upload.html           |  2 +-
 src/mod_rivet_ng/mod_rivet_cache.c | 22 ++++++++++++++++++++++
 src/mod_rivet_ng/mod_rivet_cache.h |  1 +
 src/mod_rivet_ng/rivetCore.c       |  3 +++
 6 files changed, 36 insertions(+), 2 deletions(-)


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tcl.apache.org
For additional commands, e-mail: commits-help@tcl.apache.org


[tcl-rivet] 03/06: Fix crash in cache when rvt file is not readable

Posted by mx...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

mxmanghi pushed a commit to branch 3.1
in repository https://gitbox.apache.org/repos/asf/tcl-rivet.git

commit 216ac2b772f7125638023e195fad546a1960af8d
Author: Brice Hamon <br...@ydotm.com>
AuthorDate: Fri Nov 29 14:23:52 2019 -0500

    Fix crash in cache when rvt file is not readable
---
 src/mod_rivet_ng/rivetCore.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/mod_rivet_ng/rivetCore.c b/src/mod_rivet_ng/rivetCore.c
index d830764..fe1df16 100644
--- a/src/mod_rivet_ng/rivetCore.c
+++ b/src/mod_rivet_ng/rivetCore.c
@@ -1909,6 +1909,9 @@ TCL_CMD_HEADER( Rivet_UrlScript )
 
         if (result != TCL_OK)
         {
+            // Hash cleanup
+            RivetCache_DeleteEntry(entry);
+
             Tcl_DecrRefCount(script);
             return result;
         }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tcl.apache.org
For additional commands, e-mail: commits-help@tcl.apache.org


[tcl-rivet] 02/06: Added RivetCache_DeleteEntry function

Posted by mx...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

mxmanghi pushed a commit to branch 3.1
in repository https://gitbox.apache.org/repos/asf/tcl-rivet.git

commit 1ccfa303f521c0c0276f7c4762475c54c296dc4d
Author: Brice Hamon <br...@ydotm.com>
AuthorDate: Fri Nov 29 14:23:16 2019 -0500

    Added RivetCache_DeleteEntry function
---
 src/mod_rivet_ng/mod_rivet_cache.c | 22 ++++++++++++++++++++++
 src/mod_rivet_ng/mod_rivet_cache.h |  1 +
 2 files changed, 23 insertions(+)

diff --git a/src/mod_rivet_ng/mod_rivet_cache.c b/src/mod_rivet_ng/mod_rivet_cache.c
index 721c8d9..4f997de 100644
--- a/src/mod_rivet_ng/mod_rivet_cache.c
+++ b/src/mod_rivet_ng/mod_rivet_cache.c
@@ -221,3 +221,25 @@ int RivetCache_StoreScript(rivet_thread_interp* rivet_interp, Tcl_HashEntry* ent
     }
     return 0;
 }
+
+/*
+ * -- RivetCache_DeleteEntry
+ *
+ * Cache entry delete. Removes an existing entry from a table. The memory
+ * associated with the entry itself will be freed, but the client is
+ * responsible for any cleanup associated with the entry's value, such as
+ * freeing a structure that it points to.
+ *
+ * Arguments:
+ *      Tcl_HashEntry*       entry object
+ *
+ * Results:
+ *
+ * Side Effects:
+ *
+ */
+
+void RivetCache_DeleteEntry (Tcl_HashEntry *entry)
+{
+    Tcl_DeleteHashEntry (entry);
+}
diff --git a/src/mod_rivet_ng/mod_rivet_cache.h b/src/mod_rivet_ng/mod_rivet_cache.h
index 2f54827..a316f51 100644
--- a/src/mod_rivet_ng/mod_rivet_cache.h
+++ b/src/mod_rivet_ng/mod_rivet_cache.h
@@ -31,5 +31,6 @@ EXTERN char* RivetCache_MakeKey (apr_pool_t* pool, char*         filename,
 EXTERN Tcl_HashEntry* RivetCache_EntryLookup (rivet_thread_interp* rivet_interp,char* hashKey,int* isNew);
 EXTERN Tcl_Obj* RivetCache_FetchScript (Tcl_HashEntry* entry);
 EXTERN int RivetCache_StoreScript(rivet_thread_interp* rivet_interp, Tcl_HashEntry* entry, Tcl_Obj* script);
+EXTERN void RivetCache_DeleteEntry (Tcl_HashEntry *entry);
 
 #endif /* __mod_rivet_cache_h__ */


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tcl.apache.org
For additional commands, e-mail: commits-help@tcl.apache.org


[tcl-rivet] 01/06: fixed upload example

Posted by mx...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

mxmanghi pushed a commit to branch 3.1
in repository https://gitbox.apache.org/repos/asf/tcl-rivet.git

commit cec4547539ed6e4a93a09b4d347e7c34a676c2f3
Author: Massimo Manghi <mx...@apache.org>
AuthorDate: Tue Nov 12 17:34:09 2019 +0100

    fixed upload example
---
 doc/examples/upload.html | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/examples/upload.html b/doc/examples/upload.html
index 5f20953..1e8509c 100644
--- a/doc/examples/upload.html
+++ b/doc/examples/upload.html
@@ -1,4 +1,4 @@
-<form action="foo.rvt" enctype="multipart/form-data" method="post">
+<form action="upload.rvt" enctype="multipart/form-data" method="post">
 <input type="file" name="MyUpload"></input>
 <input type="submit" value="Send File"></input>
 </form>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tcl.apache.org
For additional commands, e-mail: commits-help@tcl.apache.org


[tcl-rivet] 06/06: New branch version is 3.1.2

Posted by mx...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

mxmanghi pushed a commit to branch 3.1
in repository https://gitbox.apache.org/repos/asf/tcl-rivet.git

commit e5d9d23f9a3f449b767651b2a56cfe45c36557eb
Author: Massimo Manghi <mx...@apache.org>
AuthorDate: Mon Dec 9 11:05:10 2019 +0100

    New branch version is 3.1.2
---
 ChangeLog | 3 +++
 VERSION   | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index fb53c8e..8f77f66 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,6 @@
+2019-12-09 Massimo Manghi <mx...@apache.org>
+   * VERSION: current branch new version is 3.1.2 
+
 2019-11-29 Brice Hamon <bh...@apache.org>
    * src/mod_rivet_ng/mod_rivet_cache.h: added RivetCache_DeleteEntry
    * src/mod_rivet_ng/mod_rivet_cache.c: 
diff --git a/VERSION b/VERSION
index 94ff29c..ef538c2 100644
--- a/VERSION
+++ b/VERSION
@@ -1 +1 @@
-3.1.1
+3.1.2


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tcl.apache.org
For additional commands, e-mail: commits-help@tcl.apache.org


[tcl-rivet] 05/06: fixed crash when rvt file not readable

Posted by mx...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

mxmanghi pushed a commit to branch 3.1
in repository https://gitbox.apache.org/repos/asf/tcl-rivet.git

commit 07af70b3347c874fc479f02bb55c2f50c6259103
Author: Brice Hamon <br...@ydotm.com>
AuthorDate: Sat Nov 30 10:57:18 2019 -0500

    fixed crash when rvt file not readable
---
 ChangeLog | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ChangeLog b/ChangeLog
index 174887e..fb53c8e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,4 @@
-2019-11-29 Brice Hamon <br...@apache.org>
+2019-11-29 Brice Hamon <bh...@apache.org>
    * src/mod_rivet_ng/mod_rivet_cache.h: added RivetCache_DeleteEntry
    * src/mod_rivet_ng/mod_rivet_cache.c: 
    * src/mod_rivet_ng/rivetCore.c: fixed crash when rvt file not readable


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tcl.apache.org
For additional commands, e-mail: commits-help@tcl.apache.org


[tcl-rivet] 04/06: merge ChangeLog modifications introduced by Cache Fixup

Posted by mx...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

mxmanghi pushed a commit to branch 3.1
in repository https://gitbox.apache.org/repos/asf/tcl-rivet.git

commit e076a22cb29132fa7d54ac0d87ff3e6a50f684f9
Author: Brice Hamon <br...@ydotm.com>
AuthorDate: Sat Nov 30 10:56:12 2019 -0500

    merge ChangeLog modifications introduced by Cache Fixup
---
 ChangeLog | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 7acaa17..174887e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2019-11-29 Brice Hamon <br...@apache.org>
+   * src/mod_rivet_ng/mod_rivet_cache.h: added RivetCache_DeleteEntry
+   * src/mod_rivet_ng/mod_rivet_cache.c: 
+   * src/mod_rivet_ng/rivetCore.c: fixed crash when rvt file not readable
+
 2019-05-24 Massimo Manghi <mx...@apache.org>
     * src/mod_rivet_ng/rivetCore.c: Add Tcl_DecrRefCnt after
     RivetCache_StoreScript as this function itself calls


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@tcl.apache.org
For additional commands, e-mail: commits-help@tcl.apache.org