You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by se...@apache.org on 2010/12/10 18:07:37 UTC
svn commit: r1044444 - in /jakarta/jmeter/trunk/src:
components/org/apache/jmeter/visualizers/SamplerResultTab.java
protocol/http/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java
Author: sebb
Date: Fri Dec 10 17:07:36 2010
New Revision: 1044444
URL: http://svn.apache.org/viewvc?rev=1044444&view=rev
Log:
Inefficient use of iterator
Modified:
jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java
Modified: jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java?rev=1044444&r1=1044443&r2=1044444&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java (original)
+++ jakarta/jmeter/trunk/src/components/org/apache/jmeter/visualizers/SamplerResultTab.java Fri Dec 10 17:07:36 2010
@@ -26,6 +26,7 @@ import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.util.Date;
import java.util.LinkedHashMap;
+import java.util.Map.Entry;
import java.util.Set;
import javax.swing.BorderFactory;
@@ -286,9 +287,9 @@ public abstract class SamplerResultTab i
// Parsed response headers
LinkedHashMap<String, String> lhm = JMeterUtils.parseHeaders(sampleResult.getResponseHeaders());
- Set<String> keySet = lhm.keySet();
- for (String key : keySet) {
- resHeadersModel.addRow(new RowResult(key, lhm.get(key)));
+ Set<Entry<String, String>> keySet = lhm.entrySet();
+ for (Entry<String, String> entry : keySet) {
+ resHeadersModel.addRow(new RowResult(entry.getKey(), entry.getValue()));
}
// Fields table
Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java?rev=1044444&r1=1044443&r2=1044444&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java (original)
+++ jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/visualizers/RequestViewHTTP.java Fri Dec 10 17:07:36 2010
@@ -26,6 +26,7 @@ import java.net.URLDecoder;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.Map;
+import java.util.Map.Entry;
import java.util.Set;
import javax.swing.JPanel;
@@ -189,10 +190,9 @@ public class RequestViewHTTP implements
}
queryGet = RequestViewHTTP.decodeQuery(queryGet);
if (queryGet != null) {
- Map<String, String> mapQuery = RequestViewHTTP.getQueryMap(queryGet);
- Set<String> keys = mapQuery.keySet();
- for (String key : keys) {
- paramsModel.addRow(new RowResult(key, mapQuery.get(key)));
+ Set<Entry<String, String>> keys = RequestViewHTTP.getQueryMap(queryGet).entrySet();
+ for (Entry<String, String> entry : keys) {
+ paramsModel.addRow(new RowResult(entry.getKey(),entry.getValue()));
}
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org