[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10191: feat: add configuration for Presto cursor poll interval

[GitBox <gi...@apache.org>]

bkyryliuk commented on a change in pull request #10191:
URL: https://github.com/apache/incubator-superset/pull/10191#discussion_r447157656



##########
File path: superset/db_engine_specs/presto.py
##########
@@ -729,6 +732,11 @@ def get_create_view(
     def handle_cursor(cls, cursor: Any, query: Query, session: Session) -> None:
         """Updates progress information"""
         query_id = query.id
+        poll_interval = (
+            query.database.get_extra()

Review comment:
       it would be nice to add a property `connect_args` to the db object as this code becomes a bit repetitive:
   https://github.com/apache/incubator-superset/search?q=connect_args&unscoped_q=connect_args
   
   and by the way connect args should be part of the engine_params




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org