You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "David Smiley (JIRA)" <ji...@apache.org> on 2013/05/10 20:23:17 UTC

[jira] [Resolved] (LUCENE-4742) Rename SpatialPrefixTree's "Node" back to "Cell"

     [ https://issues.apache.org/jira/browse/LUCENE-4742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley resolved LUCENE-4742.
----------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 4.4)
                   4.3

Closing against 4.3 where it Node->Cell done.
                
> Rename SpatialPrefixTree's "Node" back to "Cell"
> ------------------------------------------------
>
>                 Key: LUCENE-4742
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4742
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spatial
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Trivial
>             Fix For: 4.3
>
>         Attachments: LUCENE-4742_Rename_spatial_Node_back_to_Cell.patch
>
>
> SpatialPrefixTree makes "Node"s which are basically a rectangular spatial region that is more colloquially referred to as a "Cell".  It was named "Cell" in the first place and for whatever reason, Ryan and/or Chris renamed it as part of extracting it to a top level class from an inner class.  Most comments and variable names still use the "cell" terminology.  I'm working on an algorithm that keeps track of a tree of "nodes" and it has gotten confusing which kind of node I'm referring to, as each Node has one cell.
> In maybe a week or so if there isn't discussion to the contrary, I'm going to commit a rename it back to "Cell".  And... while we're on this naming subject, perhaps "SpatialPrefixTree" could be named "SpatialGrid" ?  FWIW the variables referring to it are always "grid".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org