[GitHub] [trafficcontrol] zrhoffman edited a comment on pull request #5459: Code QL workflow

[GitBox <gi...@apache.org>]

zrhoffman edited a comment on pull request #5459:
URL: https://github.com/apache/trafficcontrol/pull/5459#issuecomment-769264030


   > So, regarding
   > 
   > > 1 issue was detected with this workflow: Please specify an on.push hook so that Code Scanning can compare pull requests against the state of the base branch.
   > 
   > if I add `on.push` hooks to all of those then we'll be double-testing every push to master with each of those workflows _and_ the main/scheduled one.
   
   IMO we should just nix the scheduled workflow. The scheduled workflow alone is not adequate to provide a commit baseline for the per-language workflows that we want to run against PRs.
   
   > If it's comparing against the state of master, then maybe we didn't need to split these into separate workflows? Because then the runs for languages that have no changes won't actually be doing anything, if I'm understanding that correctly.
   
   Once the runs start. they won't get far before exiting if nothing has changed, sure, but in cases where Apache has surpassed the *concurrent jobs* limit, which happens daily, each of these languages adds an additional job to the queue that holds up other Apache projects' GitHub Action runs that were queued after that job, even if nothing has changed for that language.
   
   So, it's still advantageous to split the workflow by language, since each workflow ignores different paths.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org