You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Alexandru Objelean (JIRA)" <ji...@apache.org> on 2010/11/29 19:01:11 UTC
[jira] Created: (WICKET-3205) Improve PagingNavigator markup
Improve PagingNavigator markup
-------------------------------
Key: WICKET-3205
URL: https://issues.apache.org/jira/browse/WICKET-3205
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.5-M3
Reporter: Alexandru Objelean
The PagingNavigator component is very hard to style, mostly because it doesn't have a simple semantic markup.
Something similar to:
<ul class="menu">
<li><a class="first">First page</a></li>
<li><a class="previous">Previous page</a></li>
<li><a>1</a></li>
<li class="selected"><a>2</a></li>
<li><span>...</span></li>
<li><a>4</a></li>
<li><a>5</a></li>
<li><a class="next">6</a></li>
<li><a class="last">Last page</a></li>
</ul>
I don't think it would be a good idea to add this change to wicket 1.4, since it would break the styling of existing applications. Since 1.5 is not final yet, it might be a good place to apply this change.
Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3205) Improve PagingNavigator markup
Posted by "Alexandru Objelean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965609#action_12965609 ]
Alexandru Objelean commented on WICKET-3205:
--------------------------------------------
It still doesn't have ul->li tags, which can be used to enhance paging navigation styling. Could you include these also?
> Improve PagingNavigator markup
> -------------------------------
>
> Key: WICKET-3205
> URL: https://issues.apache.org/jira/browse/WICKET-3205
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alexandru Objelean
> Assignee: Peter Ertl
>
> The PagingNavigator component is very hard to style, mostly because it doesn't have a simple semantic markup.
> Something similar to:
> <ul class="menu">
> <li><a class="first">First page</a></li>
> <li><a class="previous">Previous page</a></li>
> <li><a>1</a></li>
> <li class="selected"><a>2</a></li>
> <li><span>...</span></li>
> <li><a>4</a></li>
> <li><a>5</a></li>
> <li><a class="next">6</a></li>
> <li><a class="last">Last page</a></li>
> </ul>
> I don't think it would be a good idea to add this change to wicket 1.4, since it would break the styling of existing applications. Since 1.5 is not final yet, it might be a good place to apply this change.
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3205) Improve PagingNavigator markup
Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Ertl resolved WICKET-3205.
--------------------------------
Resolution: Fixed
Assignee: Peter Ertl
all elements should be easily addressable by CSS now
> Improve PagingNavigator markup
> -------------------------------
>
> Key: WICKET-3205
> URL: https://issues.apache.org/jira/browse/WICKET-3205
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alexandru Objelean
> Assignee: Peter Ertl
>
> The PagingNavigator component is very hard to style, mostly because it doesn't have a simple semantic markup.
> Something similar to:
> <ul class="menu">
> <li><a class="first">First page</a></li>
> <li><a class="previous">Previous page</a></li>
> <li><a>1</a></li>
> <li class="selected"><a>2</a></li>
> <li><span>...</span></li>
> <li><a>4</a></li>
> <li><a>5</a></li>
> <li><a class="next">6</a></li>
> <li><a class="last">Last page</a></li>
> </ul>
> I don't think it would be a good idea to add this change to wicket 1.4, since it would break the styling of existing applications. Since 1.5 is not final yet, it might be a good place to apply this change.
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-3205) Improve PagingNavigator
markup
Posted by "Alexandru Objelean (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12965609#action_12965609 ]
Alexandru Objelean edited comment on WICKET-3205 at 12/1/10 3:47 AM:
---------------------------------------------------------------------
It still doesn't have ul->li tags and class="selected" on selected item (LI), which can be used to enhance paging navigation styling. Could you include these also?
was (Author: alexandru.objelean):
It still doesn't have ul->li tags, which can be used to enhance paging navigation styling. Could you include these also?
> Improve PagingNavigator markup
> -------------------------------
>
> Key: WICKET-3205
> URL: https://issues.apache.org/jira/browse/WICKET-3205
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.5-M3
> Reporter: Alexandru Objelean
> Assignee: Peter Ertl
>
> The PagingNavigator component is very hard to style, mostly because it doesn't have a simple semantic markup.
> Something similar to:
> <ul class="menu">
> <li><a class="first">First page</a></li>
> <li><a class="previous">Previous page</a></li>
> <li><a>1</a></li>
> <li class="selected"><a>2</a></li>
> <li><span>...</span></li>
> <li><a>4</a></li>
> <li><a>5</a></li>
> <li><a class="next">6</a></li>
> <li><a class="last">Last page</a></li>
> </ul>
> I don't think it would be a good idea to add this change to wicket 1.4, since it would break the styling of existing applications. Since 1.5 is not final yet, it might be a good place to apply this change.
> Thanks!
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.