You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@creadur.apache.org by rd...@apache.org on 2012/08/19 14:41:44 UTC
svn commit: r1374746 -
/creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceDefinitionException.java
Author: rdonkin
Date: Sun Aug 19 12:41:43 2012
New Revision: 1374746
URL: http://svn.apache.org/viewvc?rev=1374746&view=rev
Log:
Improved performance, as reported by FindBugs
Modified:
creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceDefinitionException.java
Modified: creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceDefinitionException.java
URL: http://svn.apache.org/viewvc/creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceDefinitionException.java?rev=1374746&r1=1374745&r2=1374746&view=diff
==============================================================================
--- creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceDefinitionException.java (original)
+++ creadur/whisker/trunk/apache-whisker-app/src/main/java/org/apache/creadur/whisker/app/analysis/ResourceDefinitionException.java Sun Aug 19 12:41:43 2012
@@ -38,11 +38,16 @@ public final class ResourceDefinitionExc
Collection<ResourceDescription>> issues) {
final StringBuilder builder =
new StringBuilder("Resources definitions are incorrect. ");
- for (ResourceDefinitionError error: issues.keySet()) {
- if (!issues.get(error).isEmpty()) {
+ for (Map.Entry<
+ ResourceDefinitionError,
+ Collection<ResourceDescription>>
+ entry: issues.entrySet()) {
+ final ResourceDefinitionError error = entry.getKey();
+ final Collection<ResourceDescription> resources = entry.getValue();
+ if (!resources.isEmpty()) {
builder.append(error.getDescription()).append(": ");
boolean firstTime = true;
- for (final ResourceDescription description: issues.get(error)) {
+ for (final ResourceDescription description: resources) {
if (firstTime) {
firstTime = false;
} else {