[GitHub] [cordova-plugin-splashscreen] timbru31 commented on a change in pull request #151: Use FadeSplashScreenDuration from config.xml on browser platform

[GitBox <gi...@apache.org>]

timbru31 commented on a change in pull request #151: Use FadeSplashScreenDuration from config.xml on browser platform
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/151#discussion_r280393651
 
 

 ##########
 File path: src/browser/SplashScreenProxy.js
 ##########
 @@ -93,11 +94,13 @@ var SplashScreen = {
             localSplash = null;
             window.removeEventListener("resize", onResize, false);
 
+            var transitionCssString = "opacity " + fadeSplashScreenDuration + "ms ease-in-out";
+
             innerLocalSplash.style.opacity = '0';
-            innerLocalSplash.style["-webkit-transition"] = "opacity 1s ease-in-out";
-            innerLocalSplash.style["-moz-transition"] = "opacity 1s ease-in-out";
-            innerLocalSplash.style["-ms-transition"] = "opacity 1s ease-in-out";
-            innerLocalSplash.style["-o-transition"] = "opacity 1s ease-in-out";
+            innerLocalSplash.style["-webkit-transition"] =
+                innerLocalSplash.style["-moz-transition"] =
+                innerLocalSplash.style["-ms-transition"] =
+                innerLocalSplash.style["-o-transition"] = transitionCssString;
 
 Review comment:
   Yes - wonders of JS :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org