You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2020/04/22 14:30:02 UTC
[GitHub] [thrift] phile314 opened a new pull request #2108: Haskell: Handle incomplete reads correctly.
phile314 opened a new pull request #2108:
URL: https://github.com/apache/thrift/pull/2108
The read functions for handles promise to return *up* to the requested number of bytes. This means in case we read less bytes, we should try again to read some more bytes. This issue caused invalid frame sizes which caused arbitrary decoding failures.
I believe that the bug has been introduced in https://github.com/apache/thrift/commit/3c420072ab5388c2c00d15ada72aec5b061c4d4d
<!-- Explain the changes in the pull request below: -->
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [x] Did you squash your changes to a single commit? (not required, but preferred)
- [x] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, add ` [skip ci]` at the end of your pull request to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G closed pull request #2108: THRIFT-5211: Haskell: Handle incomplete reads correctly.
Posted by GitBox <gi...@apache.org>.
Jens-G closed pull request #2108:
URL: https://github.com/apache/thrift/pull/2108
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] zeshuai007 commented on pull request #2108: Haskell: Handle incomplete reads correctly.
Posted by GitBox <gi...@apache.org>.
zeshuai007 commented on pull request #2108:
URL: https://github.com/apache/thrift/pull/2108#issuecomment-625600796
Hi @Jens-G , I am a Thrift enthusiast, and I'm familiar with several programming languages.
I use Thrift a lot and it's awesome, cause we can flexibly choose the language we need.
During my use of Thrift, I found that it still has many features that could be optimized, such as
more detailed documentation, modern c++ compatibility, test case coverage, etc.
I am very interested in Thrift and hoping to be one of the committers if possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2108: Haskell: Handle incomplete reads correctly.
Posted by GitBox <gi...@apache.org>.
Jens-G commented on pull request #2108:
URL: https://github.com/apache/thrift/pull/2108#issuecomment-620418864
@phile314 we are looking for people who want to get more involved with Thrift as languange maintainers. Interested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org