You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/11/13 11:48:08 UTC

[GitHub] [pulsar] ltamber commented on a change in pull request #5603: [Issue 5597][pulsar-client-java] retry when getPartitionedTopicMetadata failed

ltamber commented on a change in pull request #5603: [Issue 5597][pulsar-client-java] retry when getPartitionedTopicMetadata failed
URL: https://github.com/apache/pulsar/pull/5603#discussion_r345715692
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/HttpClient.java
 ##########
 @@ -127,8 +128,9 @@ public void close() throws IOException {
     public <T> CompletableFuture<T> get(String path, Class<T> clazz) {
         final CompletableFuture<T> future = new CompletableFuture<>();
         try {
-            String requestUrl = new URL(serviceNameResolver.resolveHostUri().toURL(), path).toString();
-            String remoteHostName = serviceNameResolver.resolveHostUri().getHost();
 
 Review comment:
   @sijie maybe a bug here, the host in requestUrl not equal with remoteHostName if multi-broker service url provided, and will step forward two service url every request. please take a look.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services