[GitHub] [solr] dsmiley commented on pull request #265: SOLR-15590 - Startup and CoreContainer managed by Core Service

[GitBox <gi...@apache.org>]

dsmiley commented on pull request #265:
URL: https://github.com/apache/solr/pull/265#issuecomment-905995578


   If the idea is to leverage the constructs in the servlet API more to our advantage, then perhaps both Tracing and Rate Limiting should be servlet Filters?
   
   FWIW I don't find SolrDispatchFilter _that_ bad, though there are some warts and my other PR ( #155 ) tries to tackle some.  If you read the opening of my PR there, you'll see I dug deeper into some complexities like the cores==null checks that seem unnecessary.  Apparently those are there due to Mikhail's realization in SOLR-10615 that init() isn't necessary complete before doFilter can be called which shocked him and me too; I'm kinda in disbelief honestly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org