[jira] [Commented] (QUARKS-16) Recipe creation for split and union

["Daniel John Debrunner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/QUARKS-16?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187415#comment-15187415 ] 

Daniel John Debrunner commented on QUARKS-16:
---------------------------------------------

Looks really good, some suggestions:

1) Call the main class something related to the application, not SplitUnion, this is along the lines of split & union are tools to help me achieve what I want, so really the recipe is not for "split & union", but something like "applying different processing against a stream and combining the resulting streams into a single stream"

2) "You would use `split` when you want to split a stream's tuples among a specified number of streams."  - Kind of repeats the info in the previous sentence, which I think is a better sentence (the previous one) as it says why you want to split the stream.

3) Having spit the streams, it would be good to have actual different processing on each stream, otherwise a reader maybe left asking the question why were the streams split only to perform the exact same processing on them (the getAlert()). E.g. having a different number of transformations/filter in various streams, so they it's clear very different processing can be achieved.

4) Having a console snapshot of the graph would be a bonus, demonstrating what the resulting flow looked like. Maybe even an annotated image.

5) Hopefully the code could be added in as a sample in the repo.

> Recipe creation for split and union
> -----------------------------------
>
>                 Key: QUARKS-16
>                 URL: https://issues.apache.org/jira/browse/QUARKS-16
>             Project: Quarks
>          Issue Type: Improvement
>          Components: Documentation
>            Reporter: Queenie Ma
>            Priority: Minor
>              Labels: documentation, enhancement
>         Attachments: HeartMonitor.java, SplitUnion.java, split_union.md
>
>
> I wrote up a recipe on how to split and union streams. I'd like to get some feedback on the sample code and the recipe walkthrough.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)