You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "biggates (via GitHub)" <gi...@apache.org> on 2023/06/15 11:25:18 UTC
[GitHub] [echarts] biggates opened a new pull request, #18768: Fix 18754: Adds sampling support to dataZoomSlider
biggates opened a new pull request, #18768:
URL: https://github.com/apache/echarts/pull/18768
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
- Adds `sampling` support in `dataZoom`
### Fixed issues
- #18754
## Details
### Before: What was the problem?
the sampling method in `dataZoomSlider` is not the same as in series. In rare cases (lots of fast changing points), it may result in incorrect shape.
### After: How does it behave after the fixing?
called the same processing function in `dataZoomSlider` as in `dataSample()`, and will fallback to the old implementation if sampling is not applicable.
## Document Info
One of the following should be checked.
- [ ] This PR doesn't relate to document changes
- [x] The document should be updated later
- [ ] The document changes have been made in apache/echarts-doc#xxx
This PR will add an additional optional configuration `sampling` in `dataZoom` so an update is required.
## Misc
### ZRender Changes
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
- test case: `dataZoom-sampling.html`
## Others
### Merging options
- [x] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #18768: Fix 18754: Adds sampling support to dataZoomSlider
Posted by "echarts-bot[bot] (via GitHub)" <gi...@apache.org>.
echarts-bot[bot] commented on PR #18768:
URL: https://github.com/apache/echarts/pull/18768#issuecomment-1592863985
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
Document changes are required in this PR. Please also make a PR to [apache/echarts-doc](https://github.com/apache/echarts-doc) for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the `PR: awaiting doc` label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org