You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "korowa (via GitHub)" <gi...@apache.org> on 2023/02/16 08:07:57 UTC
[GitHub] [arrow-datafusion] korowa opened a new pull request, #5295: `datafusion.optimizer.repartition_file_scans` enabled by default
korowa opened a new pull request, #5295:
URL: https://github.com/apache/arrow-datafusion/pull/5295
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #5125.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
I guess, it's fine to enable repartitioning by default in 19.0.0 (or, more likely, first release candidate for 19.0.0)
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Default value of `datafusion.optimizer.repartition_file_scans` is `true` now.
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
Covered by existing tests
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
Repartitioning of file scans will be enabled by default
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5295: `datafusion.optimizer.repartition_file_scans` enabled by default
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5295:
URL: https://github.com/apache/arrow-datafusion/pull/5295#issuecomment-1436991550
Benchmark runs are scheduled for baseline = cfbb14d9c0b8f4a86ed12d716a55c1dba3791e8b and contender = 222205df2e26befa3f7f8d862fefea413fbafc4d. 222205df2e26befa3f7f8d862fefea413fbafc4d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ff22fab5fb3846c7b9c611a167d449fb...7e96dd70c5684cb68b71a32eca9fb105/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/7924af1c8ea3441cba4db8f1561c5f27...e7187a367fbf484e9a976735b6dc26d0/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/feb147c017d24cad81d5c7b206d07189...5e22f64af4cb4c6283ecb8e8aaaaea1b/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5d2e925e77804fc79a6a64ab47a3a9e7...9991c2d7ab99444781696a5896a327e4/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ozankabak commented on pull request #5295: `datafusion.optimizer.repartition_file_scans` enabled by default
Posted by "ozankabak (via GitHub)" <gi...@apache.org>.
ozankabak commented on PR #5295:
URL: https://github.com/apache/arrow-datafusion/pull/5295#issuecomment-1433725312
This should help with mitigating the "low-performance" impression -- many people will not dig deep to configuration options and simply try things out with OOTB defaults.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5295: `datafusion.optimizer.repartition_file_scans` enabled by default
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5295:
URL: https://github.com/apache/arrow-datafusion/pull/5295#issuecomment-1434748704
I will plan to merge this sometime over the weekend unless anyone else would like time to comment or offer more thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5295: `datafusion.optimizer.repartition_file_scans` enabled by default
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5295:
URL: https://github.com/apache/arrow-datafusion/pull/5295#issuecomment-1433594633
What do you think @tustvold @Dandandan @andygrove -- any concerns about turning on automatic repartitioned file scans (which allows scanning a single large parquet file in parallel)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5295: `datafusion.optimizer.repartition_file_scans` enabled by default
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5295:
URL: https://github.com/apache/arrow-datafusion/pull/5295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #5295: `datafusion.optimizer.repartition_file_scans` enabled by default
Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener commented on PR #5295:
URL: https://github.com/apache/arrow-datafusion/pull/5295#issuecomment-1436051638
> This should help with mitigating the "low-performance" impression -- many people will not dig deep to configuration options and simply try things out with OOTB defaults.
Look great to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org