You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/29 23:32:15 UTC
[GitHub] [incubator-nuttx-apps] slorquet opened a new pull request, #1330: Separate NSH ability to mount a romfs at /etc and to run init scripts.
slorquet opened a new pull request, #1330:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1330
## Summary
This is useful because the board can mount its own filesystem without requiring any particular type of filesystem and mountpoint.
## Impact
Anyone using nsh init scripts need to regenerate their config.
## Testing
Build is OK, Kconfig menus work as expected
New code with an init script on a custom FS runs on my custom stm32f429 "hn70ap" board.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] slorquet commented on a diff in pull request #1330: Separate NSH ability to mount a romfs at /etc and to run init scripts.
Posted by GitBox <gi...@apache.org>.
slorquet commented on code in PR #1330:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1330#discussion_r984299369
##########
nshlib/Kconfig:
##########
@@ -857,13 +832,75 @@ config NSH_FATMOUNTPT
will mount a FAT FS under /tmp. This is the location where the FAT
FS will be mounted. Default is "/tmp".
+endif # NSH_ROMFSETC
+
+config NSH_RUNSYSINITSCRIPT
Review Comment:
I'm cancelling this PR. I will come up with a new way to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] slorquet commented on pull request #1330: Separate NSH ability to mount a romfs at /etc and to run init scripts.
Posted by GitBox <gi...@apache.org>.
slorquet commented on PR #1330:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1330#issuecomment-1263217908
I'm cancelling this PR. I will come up with a new way to do it that limit breakage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] slorquet commented on a diff in pull request #1330: Separate NSH ability to mount a romfs at /etc and to run init scripts.
Posted by GitBox <gi...@apache.org>.
slorquet commented on code in PR #1330:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1330#discussion_r984294652
##########
nshlib/Kconfig:
##########
@@ -857,13 +832,75 @@ config NSH_FATMOUNTPT
will mount a FAT FS under /tmp. This is the location where the FAT
FS will be mounted. Default is "/tmp".
+endif # NSH_ROMFSETC
+
+config NSH_RUNSYSINITSCRIPT
Review Comment:
Yes it will. Do you have any idea to avoid that?
##########
nshlib/Kconfig:
##########
@@ -857,13 +832,75 @@ config NSH_FATMOUNTPT
will mount a FAT FS under /tmp. This is the location where the FAT
FS will be mounted. Default is "/tmp".
+endif # NSH_ROMFSETC
+
+config NSH_RUNSYSINITSCRIPT
+ bool "Run a sysinit script"
+ default n
+ select NSH_AUTOSCRIPTS
+
+if NSH_RUNSYSINITSCRIPT
+
+config NSH_SYSINITSCRIPT
+ string "Path to sysinit script"
+ default "/etc/init.d/rc.sysinit"
+ ---help---
+ This is the path to the sysinit script executed by nsh at boot.
+ The default is init.d/rc.sysinit. This script can be in a ROMFS mounted
+ by NSH or in any other filesystem that was mounted by the board logic.
+
+endif
+
+config NSH_RUNINITSCRIPT
+ bool "Run a startup script"
+ default n
Review Comment:
My kconfig refused to work with spaces but ok, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] slorquet closed pull request #1330: Separate NSH ability to mount a romfs at /etc and to run init scripts.
Posted by GitBox <gi...@apache.org>.
slorquet closed pull request #1330: Separate NSH ability to mount a romfs at /etc and to run init scripts.
URL: https://github.com/apache/incubator-nuttx-apps/pull/1330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1330: Separate NSH ability to mount a romfs at /etc and to run init scripts.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1330:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1330#discussion_r984166538
##########
nshlib/Kconfig:
##########
@@ -857,13 +832,75 @@ config NSH_FATMOUNTPT
will mount a FAT FS under /tmp. This is the location where the FAT
FS will be mounted. Default is "/tmp".
+endif # NSH_ROMFSETC
+
+config NSH_RUNSYSINITSCRIPT
+ bool "Run a sysinit script"
+ default n
+ select NSH_AUTOSCRIPTS
+
+if NSH_RUNSYSINITSCRIPT
+
+config NSH_SYSINITSCRIPT
+ string "Path to sysinit script"
+ default "/etc/init.d/rc.sysinit"
+ ---help---
+ This is the path to the sysinit script executed by nsh at boot.
+ The default is init.d/rc.sysinit. This script can be in a ROMFS mounted
+ by NSH or in any other filesystem that was mounted by the board logic.
+
+endif
+
+config NSH_RUNINITSCRIPT
+ bool "Run a startup script"
+ default n
Review Comment:
please change ALL indent in Kconfig from space to tab
##########
nshlib/Kconfig:
##########
@@ -857,13 +832,75 @@ config NSH_FATMOUNTPT
will mount a FAT FS under /tmp. This is the location where the FAT
FS will be mounted. Default is "/tmp".
+endif # NSH_ROMFSETC
+
+config NSH_RUNSYSINITSCRIPT
Review Comment:
the new option will break all config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] slorquet commented on a diff in pull request #1330: Separate NSH ability to mount a romfs at /etc and to run init scripts.
Posted by GitBox <gi...@apache.org>.
slorquet commented on code in PR #1330:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1330#discussion_r984294652
##########
nshlib/Kconfig:
##########
@@ -857,13 +832,75 @@ config NSH_FATMOUNTPT
will mount a FAT FS under /tmp. This is the location where the FAT
FS will be mounted. Default is "/tmp".
+endif # NSH_ROMFSETC
+
+config NSH_RUNSYSINITSCRIPT
Review Comment:
Yes it will. Do you have any idea to avoid that?
edit: maybe to have some new options default to Y or some other arrangement to make it work?
Like: Keep all the existing options, and add new one to "execute scripts without having the /etc ROMFS mounted? This is doable but did not have this idea yesterday at 1am lol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org