You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ch...@apache.org on 2023/02/07 11:04:50 UTC
[kyuubi] branch branch-1.6 updated: [KYUUBI #4247] `build/mvn` should use the exact version defined in `pom.xml`
This is an automated email from the ASF dual-hosted git repository.
chengpan pushed a commit to branch branch-1.6
in repository https://gitbox.apache.org/repos/asf/kyuubi.git
The following commit(s) were added to refs/heads/branch-1.6 by this push:
new 1b3a3a5a7 [KYUUBI #4247] `build/mvn` should use the exact version defined in `pom.xml`
1b3a3a5a7 is described below
commit 1b3a3a5a7cbb8456036bfe11a3ecf8adf5a87038
Author: edddddy <rm...@qq.com>
AuthorDate: Tue Feb 7 19:04:10 2023 +0800
[KYUUBI #4247] `build/mvn` should use the exact version defined in `pom.xml`
### _Why are the changes needed?_
As mentioned in #4247, it seems to be better that using the same maven version with master. Thus, modify the version check logic in `build/mvn` from equal or greater to equal.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
Closes #4261 from edddddy/mvn_ver_cp.
Closes #4247
11f19eca1 [1456173400] change the if condition to equal
Lead-authored-by: edddddy <rm...@qq.com>
Co-authored-by: 1456173400 <14...@qq.com>
Signed-off-by: Cheng Pan <ch...@apache.org>
(cherry picked from commit 95318d578289249e1380140ec9b19c46c2543235)
Signed-off-by: Cheng Pan <ch...@apache.org>
---
build/mvn | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/build/mvn b/build/mvn
index d67638ba2..de697f410 100755
--- a/build/mvn
+++ b/build/mvn
@@ -76,7 +76,7 @@ install_mvn() {
fi
# See simple version normalization: http://stackoverflow.com/questions/16989598/bash-comparing-version-numbers
function version { echo "$@" | awk -F. '{ printf("%03d%03d%03d\n", $1,$2,$3); }'; }
- if [ $(version $MVN_DETECTED_VERSION) -lt $(version $MVN_VERSION) ]; then
+ if [ $(version $MVN_DETECTED_VERSION) -eq $(version $MVN_VERSION) ]; then
local APACHE_MIRROR=${APACHE_MIRROR:-'https://archive.apache.org/dist/'}
install_app \