You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/09/02 05:33:38 UTC

Re: Review Request 68067: Added flag to control GC-ing of nested container sandboxes.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68067/#review208236
-----------------------------------------------------------


Ship it!




Ship It!

- Qian Zhang


On Aug. 23, 2018, 2:33 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68067/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2018, 2:33 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
>     https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This adds an agent flag which enables garbage collection of finished
> nested container sandboxes.
> 
> This also updates some documentation and recommends enabling this flag
> when the user uses the same default executor to launch multiple tasks.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG d423394cb883955690248ab0fbde2dc7a1c2fff0 
>   docs/configuration/agent.md e98a9786aa2d1f5c87aec4db8b65457c3293156e 
>   docs/operator-http-api.md 9a37dc55b7279b4b30c87f850aeddf0e83a3c2e7 
>   docs/sandbox.md 3b44112b9b1de7fcb31a9bd3f56289b4ed9e9f13 
>   docs/upgrades.md dc61f9b92591bfd98352f1f50bfe7e2c48d3c9f4 
>   src/slave/flags.hpp bff194fef98f38a8b91d86ef4ec99889d0cfe31f 
>   src/slave/flags.cpp e017f3921a0bccc03f6ef639a04163bf7fc4e79b 
>   src/slave/http.cpp 1b6d266a1a7821c9de6871cbca43317b3c392a32 
> 
> 
> Diff: https://reviews.apache.org/r/68067/diff/5/
> 
> 
> Testing
> -------
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>