[GitHub] [spark] maryannxue commented on a change in pull request #24136: [SPARK-27088][SQL] Apply conf "spark.sql.optimizer.planChangeLog.leve…

[GitBox <gi...@apache.org>]

maryannxue commented on a change in pull request #24136: [SPARK-27088][SQL] Apply conf "spark.sql.optimizer.planChangeLog.leve…
URL: https://github.com/apache/spark/pull/24136#discussion_r267531589
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -201,6 +201,14 @@ object SQLConf {
     .stringConf
     .createOptional
 
+  val OPTIMIZER_PLAN_CHANGE_LOG_BATCHES = buildConf("spark.sql.optimizer.planChangeLog.batches")
 
 Review comment:
   As I understand this is not for the log level, rather a filter for specific the batches to log, i.e., a counterpart to "spark.sql.optimizer.planChangeLog.rules". Since the names of the batches are very different from those of the rules and feel a little "random", I don't think it's a good idea to reuse that conf. Moreover, it could be used as trick to turn off batch logging.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org