You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by cp...@apache.org on 2016/12/01 21:02:21 UTC
[3/3] lucene-solr:jira/solr-6203: SOLR-6203: added reply to
would-be-nice todo/comment/question in grouping/Command.java
SOLR-6203: added reply to would-be-nice todo/comment/question in grouping/Command.java
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/6476f286
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/6476f286
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/6476f286
Branch: refs/heads/jira/solr-6203
Commit: 6476f286799c8aebe2fe81563b8976470145440c
Parents: 6043210
Author: Christine Poerschke <cp...@apache.org>
Authored: Thu Dec 1 20:58:12 2016 +0000
Committer: Christine Poerschke <cp...@apache.org>
Committed: Thu Dec 1 20:59:16 2016 +0000
----------------------------------------------------------------------
solr/core/src/java/org/apache/solr/search/grouping/Command.java | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/6476f286/solr/core/src/java/org/apache/solr/search/grouping/Command.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/search/grouping/Command.java b/solr/core/src/java/org/apache/solr/search/grouping/Command.java
index fb64e8a..521855b 100644
--- a/solr/core/src/java/org/apache/solr/search/grouping/Command.java
+++ b/solr/core/src/java/org/apache/solr/search/grouping/Command.java
@@ -27,7 +27,7 @@ import java.util.List;
* This is an abstraction on how the {@link Collector} instances are created
* and how the results are retrieved from the {@link Collector} instances.
*
- * @lucene.experimental
+ * @lucene.experimental <===
*/
public interface Command<T> {
@@ -73,6 +73,9 @@ public interface Command<T> {
// JTODO Would be nice to add these two but don't want to break anything for users of the interface.
+ // CP reply: The class is marked @lucene.experimental and based on that I think we would be okay to make
+ // (reasonable) changes to the interface, such as replacing the ...Sort with a ...SortSpec
+ // if that is needed.
// /**
// * @return The group SortSpec (overall sort)
// */