You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/02/10 07:35:38 UTC
[GitHub] [dolphinscheduler-website] QuakeWang opened a new pull request #687: [E2E] [Picture] Update the picture
QuakeWang opened a new pull request #687:
URL: https://github.com/apache/dolphinscheduler-website/pull/687
As the original images were in Chinese, now the English version has been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #687: [E2E] [Picture] Update the picture
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #687:
URL: https://github.com/apache/dolphinscheduler-website/pull/687#discussion_r805141828
##########
File path: development/en-us/e2e-test.md
##########
@@ -104,7 +104,7 @@ The goToTab method is provided in SecurityPage to test the corresponding sidebar
}
```
-
+
Review comment:
One dead link find by CI
##########
File path: development/en-us/e2e-test.md
##########
@@ -104,7 +104,7 @@ The goToTab method is provided in SecurityPage to test the corresponding sidebar
}
```
-
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] QuakeWang commented on a change in pull request #687: [E2E] [Picture] Update the picture
Posted by GitBox <gi...@apache.org>.
QuakeWang commented on a change in pull request #687:
URL: https://github.com/apache/dolphinscheduler-website/pull/687#discussion_r804616267
##########
File path: development/en-us/e2e-test.md
##########
@@ -104,7 +104,7 @@ The goToTab method is provided in SecurityPage to test the corresponding sidebar
}
```
-
+
Review comment:
> I think we should just add English version picture is better
Do you mean that both Chinese and English choose to use the English version of the image?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #687: [E2E] [Picture] Update the picture
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #687:
URL: https://github.com/apache/dolphinscheduler-website/pull/687#issuecomment-1037092911
FYI, For a quick look at CI, I add this change directly in the https://github.com/apache/dolphinscheduler-website/pull/687#discussion_r805141789, holp you do not mind it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie merged pull request #687: [E2E] [Picture] Update the picture
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged pull request #687:
URL: https://github.com/apache/dolphinscheduler-website/pull/687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #687: [E2E] [Picture] Update the picture
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #687:
URL: https://github.com/apache/dolphinscheduler-website/pull/687#discussion_r804596229
##########
File path: development/en-us/e2e-test.md
##########
@@ -104,7 +104,7 @@ The goToTab method is provided in SecurityPage to test the corresponding sidebar
}
```
-
+
Review comment:
I think we should just add English version picture is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on pull request #687: [E2E] [Picture] Update the picture
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on pull request #687:
URL: https://github.com/apache/dolphinscheduler-website/pull/687#issuecomment-1036153627
It is ready to go now? @QuakeWang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] QuakeWang commented on a change in pull request #687: [E2E] [Picture] Update the picture
Posted by GitBox <gi...@apache.org>.
QuakeWang commented on a change in pull request #687:
URL: https://github.com/apache/dolphinscheduler-website/pull/687#discussion_r805129879
##########
File path: development/en-us/e2e-test.md
##########
@@ -104,7 +104,7 @@ The goToTab method is provided in SecurityPage to test the corresponding sidebar
}
```
-
+
Review comment:
> yeah， thatwhat i mean
done : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-website] zhongjiajie commented on a change in pull request #687: [E2E] [Picture] Update the picture
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on a change in pull request #687:
URL: https://github.com/apache/dolphinscheduler-website/pull/687#discussion_r804628814
##########
File path: development/en-us/e2e-test.md
##########
@@ -104,7 +104,7 @@ The goToTab method is provided in SecurityPage to test the corresponding sidebar
}
```
-
+
Review comment:
yeah， thatwhat i mean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org