You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "JustGui (via GitHub)" <gi...@apache.org> on 2024/04/08 12:52:10 UTC
[I] Problem when creating dataset/chart/dashboard if database is Trino with TRINO_EXPAND_ROWS [superset]
JustGui opened a new issue, #27939:
URL: https://github.com/apache/superset/issues/27939
### Bug description
Importing a dataset/chart/dashboard linked to a Trino database with TRINO_EXPAND_ROWS=True and "Row expansion in schema" activated, returns an error via the API & Superset interface.
To avoid this error, you need to remove the following lines from the YAML file before importing:
```
schema_options:
expand_rows: true
```
Superset API shouldn't break when new extras are added to a database as the database itself isn't altered when we remove existing extras from the YAML file and import the dataset with this altered schema. It seems like the extra in the YAML doesn't really matter at the end, so it shouldn't break the API.
Thx!
### How to reproduce the bug
1. Add the feature flag "TRINO_EXPAND_ROWS": True
2. Enable "Row expansion in schema" on a Trino database
3. Export a dataset as a zip using this database via the interface
4. Import again this dataset (the same zip file)
5. After validating, instead of proposing to overwrite your dataset, it will return an error
### Screenshots/recordings
_No response_
### Superset version
master / latest-dev
### Python version
3.10
### Node version
16
### Browser
Firefox
### Additional context
_No response_
### Checklist
- [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Problem when creating dataset/chart/dashboard if database is Trino with TRINO_EXPAND_ROWS [superset]
Posted by "JustGui (via GitHub)" <gi...@apache.org>.
JustGui commented on issue #27939:
URL: https://github.com/apache/superset/issues/27939#issuecomment-2726484122
I still have the same issue on 5.0.0rc1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Problem when creating dataset/chart/dashboard if database is Trino with TRINO_EXPAND_ROWS [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #27939: Problem when creating dataset/chart/dashboard if database is Trino with TRINO_EXPAND_ROWS
URL: https://github.com/apache/superset/issues/27939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Problem when creating dataset/chart/dashboard if database is Trino with TRINO_EXPAND_ROWS [superset]
Posted by "JustGui (via GitHub)" <gi...@apache.org>.
JustGui commented on issue #27939:
URL: https://github.com/apache/superset/issues/27939#issuecomment-2726535867
But we could close this one as it's the same issue as https://github.com/apache/superset/issues/27027#issuecomment-2686791496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Problem when creating dataset/chart/dashboard if database is Trino with TRINO_EXPAND_ROWS [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #27939:
URL: https://github.com/apache/superset/issues/27939#issuecomment-2704694545
Is this still an issue in 4.x (or 5.0 RCs)? Was tempted to close this as stale, but nervous about doing so :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Problem when creating dataset/chart/dashboard if database is Trino with TRINO_EXPAND_ROWS [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #27939:
URL: https://github.com/apache/superset/issues/27939#issuecomment-2960557092
Actually, if anyone can try on `master` and see if https://github.com/apache/superset/pull/32657 fixed this, it would be appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Problem when creating dataset/chart/dashboard if database is Trino with TRINO_EXPAND_ROWS [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #27939:
URL: https://github.com/apache/superset/issues/27939#issuecomment-2960554829
Thanks... closing in favor of #27027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org