You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "benweidig (via GitHub)" <gi...@apache.org> on 2023/05/18 11:22:42 UTC
[GitHub] [tapestry-5] benweidig opened a new pull request, #40: TAP5-2708/2753: CssCompressor updates and CSS variable fixes
benweidig opened a new pull request, #40:
URL: https://github.com/apache/tapestry-5/pull/40
I've updated the CssCompressor with the latest commit https://github.com/yui/yuicompressor/commit/cf0497e53fffe4ddbd50e71518c40e0c07d120de and moved all CSS related tests and create a Spec.
The YUI Compressor is dead, and not in a nice state...
To make it work I had to fix some compile and runtime issues:
- Duplicate variable declaration of "oldCss"
- Faulty non-escaped regex
- zeros.css test failed
I'm not 100% sure the CssCompressor behaves 100% as before, but it's a necessary trade-off so it can be improved further.
We had multiple issues with it before, and I looked for possible replacements, but only found quite large dependencies compared to the single Java file right now.
The next steps would be going over the issues of YUI Compressor, create test files, and adapt our code accordingly.
After that, I may want to improve it by cleaning it up and pre-compiling Regexes, etc.
Also, an easier way to disable compression for single files would be nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[GitHub] [tapestry-5] benweidig commented on pull request #40: TAP5-2708/2753: CssCompressor updates and CSS variable fixes
Posted by "benweidig (via GitHub)" <gi...@apache.org>.
benweidig commented on PR #40:
URL: https://github.com/apache/tapestry-5/pull/40#issuecomment-1604492085
The PR was merged manually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[GitHub] [tapestry-5] benweidig closed pull request #40: TAP5-2708/2753: CssCompressor updates and CSS variable fixes
Posted by "benweidig (via GitHub)" <gi...@apache.org>.
benweidig closed pull request #40: TAP5-2708/2753: CssCompressor updates and CSS variable fixes
URL: https://github.com/apache/tapestry-5/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org