You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2017/09/11 13:20:42 UTC
[GitHub] brooklyn-server pull request #814: Fix back compat of catalog java api
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-server/pull/814
Fix back compat of catalog java api
The switch to osgi bundles and `TypeRegistry` caused confusion where people were consuming the `BrooklynCatalog` API and expecting (reasonably) to see the things they've added. This PR makes those methods also look in the `TypeRegistry` with `...Legacy(...)` methods added to explicitly search only in the catalog.
All methods are deprecated so in 1.0 we can hopefully delete!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-server fix-back-compat-of-catalog-java-api
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/814.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #814
----
commit 6a8800d6cfd760f287ff6eb9a979483651f88bda
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2017-09-11T12:19:33Z
fix Catalog method backwards compatibility, and deprecate them
now they delegate to TypeRegistry if can't find locally
commit 4a4dd092f5a63946bf05f624f878b09defa392ef
Author: Alex Heneveld <al...@cloudsoftcorp.com>
Date: 2017-09-11T13:15:29Z
better preserve backwards compat (fixing tests) and tidy warnings/comments
----
---
[GitHub] brooklyn-server pull request #814: Fix back compat of catalog java api
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/814
---