You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2022/11/20 12:35:28 UTC

[commons-statistics] 02/04: Use assertEquals in place of using Precision with assertTrue

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git

commit 280b177006b4e304dca162350a647d495e4261f7
Author: Alex Herbert <ah...@apache.org>
AuthorDate: Sat Nov 19 07:45:29 2022 +0000

    Use assertEquals in place of using Precision with assertTrue
---
 .../distribution/ExponentialDistributionTest.java  | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ExponentialDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ExponentialDistributionTest.java
index c52b350..6c8c4bf 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ExponentialDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ExponentialDistributionTest.java
@@ -17,7 +17,6 @@
 package org.apache.commons.statistics.distribution;
 
 import java.math.BigDecimal;
-import org.apache.commons.numbers.core.Precision;
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.params.ParameterizedTest;
@@ -58,19 +57,20 @@ class ExponentialDistributionTest extends BaseContinuousDistributionTest {
     @Test
     void testAdditionalDensity() {
         final ExponentialDistribution d1 = ExponentialDistribution.of(1);
-        Assertions.assertTrue(Precision.equals(0.0, d1.density(-1e-9), 1));
-        Assertions.assertTrue(Precision.equals(1.0, d1.density(0.0), 1));
-        Assertions.assertTrue(Precision.equals(0.0, d1.density(1000.0), 1));
-        Assertions.assertTrue(Precision.equals(Math.exp(-1), d1.density(1.0), 1));
-        Assertions.assertTrue(Precision.equals(Math.exp(-2), d1.density(2.0), 1));
+        Assertions.assertEquals(0.0, d1.density(-1e-9));
+        Assertions.assertEquals(1.0, d1.density(0.0));
+        Assertions.assertEquals(0.0, d1.density(1000.0));
+        Assertions.assertEquals(Math.exp(-1), d1.density(1.0));
+        Assertions.assertEquals(Math.exp(-2), d1.density(2.0));
 
         final ExponentialDistribution d2 = ExponentialDistribution.of(3);
-        Assertions.assertTrue(Precision.equals(1 / 3.0, d2.density(0.0), 1));
-        // computed using  print(dexp(1, rate=1/3), digits=10) in R 2.5
-        Assertions.assertEquals(0.2388437702, d2.density(1.0), 1e-8);
+        Assertions.assertEquals(1 / 3.0, d2.density(0.0));
 
-        // computed using  print(dexp(2, rate=1/3), digits=10) in R 2.5
-        Assertions.assertEquals(0.1711390397, d2.density(2.0), 1e-8);
+        // computed using R 3.4.0: print(dexp(1, rate=1/3), digits=20)
+        Assertions.assertEquals(0.23884377019126309949, d2.density(1.0), 1e-15);
+
+        // computed using R 3.4.0: print(dexp(2, rate=1/3), digits=20)
+        Assertions.assertEquals(0.17113903967753066326, d2.density(2.0), 1e-15);
     }
 
     @Test