You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/05/12 16:15:00 UTC
[GitHub] [rocketmq] mxsm opened a new issue #2879: Remove RouteInfoManager class log print
mxsm opened a new issue #2879:
URL: https://github.com/apache/rocketmq/issues/2879
```java
public void printAllPeriodically() {
try {
try {
this.lock.readLock().lockInterruptibly();
log.info("--------------------------------------------------------");
{
log.info("topicQueueTable SIZE: {}", this.topicQueueTable.size());
Iterator<Entry<String, List<QueueData>>> it = this.topicQueueTable.entrySet().iterator();
while (it.hasNext()) {
Entry<String, List<QueueData>> next = it.next();
log.info("topicQueueTable Topic: {} {}", next.getKey(), next.getValue());
}
}
{
log.info("brokerAddrTable SIZE: {}", this.brokerAddrTable.size());
Iterator<Entry<String, BrokerData>> it = this.brokerAddrTable.entrySet().iterator();
while (it.hasNext()) {
Entry<String, BrokerData> next = it.next();
log.info("brokerAddrTable brokerName: {} {}", next.getKey(), next.getValue());
}
}
{
log.info("brokerLiveTable SIZE: {}", this.brokerLiveTable.size());
Iterator<Entry<String, BrokerLiveInfo>> it = this.brokerLiveTable.entrySet().iterator();
while (it.hasNext()) {
Entry<String, BrokerLiveInfo> next = it.next();
log.info("brokerLiveTable brokerAddr: {} {}", next.getKey(), next.getValue());
}
}
{
log.info("clusterAddrTable SIZE: {}", this.clusterAddrTable.size());
Iterator<Entry<String, Set<String>>> it = this.clusterAddrTable.entrySet().iterator();
while (it.hasNext()) {
Entry<String, Set<String>> next = it.next();
log.info("clusterAddrTable clusterName: {} {}", next.getKey(), next.getValue());
}
}
} finally {
this.lock.readLock().unlock();
}
} catch (Exception e) {
log.error("printAllPeriodically Exception", e);
}
}
```
log.info("--------------------------------------------------------");
There's no point in printing. I think the print can be removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky commented on issue #2879: Remove RouteInfoManager class log print
Posted by GitBox <gi...@apache.org>.
duhenglucky commented on issue #2879:
URL: https://github.com/apache/rocketmq/issues/2879#issuecomment-840228172
@mxsm This horizontal line is mainly used to separate the printing of metadata, so that the changes of metadata can be displayed more clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling commented on issue #2879: Remove RouteInfoManager class log print
Posted by GitBox <gi...@apache.org>.
vongosling commented on issue #2879:
URL: https://github.com/apache/rocketmq/issues/2879#issuecomment-843677707
Spring is just spring. You could finish it completely instead of just removing this highlighted line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] vongosling closed issue #2879: Remove RouteInfoManager class log print
Posted by GitBox <gi...@apache.org>.
vongosling closed issue #2879:
URL: https://github.com/apache/rocketmq/issues/2879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] mxsm commented on issue #2879: Remove RouteInfoManager class log print
Posted by GitBox <gi...@apache.org>.
mxsm commented on issue #2879:
URL: https://github.com/apache/rocketmq/issues/2879#issuecomment-840270282
> @mxsm This horizontal line is mainly used to separate the printing of metadata, so that the changes of metadata can be displayed more clearly.
this way to be displayed more clearly. In other famous projects like spring, I don't see this way. Maybe you can add some description rather than print horizontal line only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org