You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2016/02/19 02:21:22 UTC

[GitHub] incubator-zeppelin pull request: [HOTFIX] Add checkpoint() method ...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/726

    [HOTFIX] Add checkpoint() method implementation

    ### What is this PR for?
    While merging https://github.com/apache/incubator-zeppelin/pull/697, NotebookRepo API changed.
    And it breaks master branch. This PR implement checkpoint() method to fix it.
    
    ### What type of PR is it?
    Hot Fix
    
    ### Todos
    * [x] - Implement checkpoint()
    
    ### Is there a relevant Jira issue?
    ZEPPELIN-656
    
    ### How should this be tested?
    build master branch
    
    ### Screenshots (if appropriate)
    N/A
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/incubator-zeppelin ZEPPELIN-656_hotfix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/726.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #726
    
----
commit 3a61696a8c3a15066012c9d4d52ed232cb9b8b54
Author: Lee moon soo <mo...@apache.org>
Date:   2016-02-19T01:21:39Z

    Add checkpoint() method implementation

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Add checkpoint() method ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/726


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Add checkpoint() method ...

Posted by granturing <gi...@git.apache.org>.

Github user granturing commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/726#issuecomment-186005929
  
    looks good, thanks for handling that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Add checkpoint() method ...

Posted by khalidhuseynov <gi...@git.apache.org>.

Github user khalidhuseynov commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/726#issuecomment-186004603
  
    Thanks for catching up with latest API, looks good!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Add checkpoint() method ...

Posted by felixcheung <gi...@git.apache.org>.

Github user felixcheung commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/726#issuecomment-186005517
  
    looks good


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: [HOTFIX] Add checkpoint() method ...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/726#issuecomment-186008277
  
    Thanks guys for review.
    I'm merging it as a hotfix


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---